-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] increase the code coverage of R-package #269
Comments
yes definitely! I host an open source hack night at my company every two weeks. Next one is next Wednesday...mind if I unleash the attendees on this? Seems like a good learning opportunity and a good task for people who know R but are learning how open source works. And also it would be valuable for the project! |
@StrikerRUS I'm ok with @jameslamb 's idea. |
Wow, that's cool! Many thanks! |
Great, thanks! |
@jameslamb Hi! Can't wait to see your R-ninjas here! 😄 |
@StrikerRUS hey my team and I did spend a few hours working on hits. Unfortunately we were never able to get past the "skip if Python modules don't exist" checks (see my comment on #276 ). I am definitely interested in coming back and trying but can say it was pretty difficult to get the tests to run :/ |
It's something I'm curious, maybe you can tell me...did CRAN ever complain about the use of Teach me! |
@jameslamb Thanks a lot for your tries! I really appreciate it! Unfortunately, I'm completely unfamiliar with R language :-( . Everything R-related was developed by @mlampros and is maintained by him too (many thanks to him for this BTW!). The only thing I've done was environment setup for R on CI services: Travis and Appveyor. I remember, @mlampros told me that every test is indeed skipped at CRAN, because it's impossible to install required Python package ( |
Hey yeah I was thinking about that! We should make Yeah CRAN (very reasonably) does not let you know install stuff on their machines. This is something my friends @bburns632 and @jayqi and I working on I think to feel confident in the R tests here we'd need to run them on Travis AND explicitly put in a check on @StrikerRUS to your comment "I'm completely unfamiliar with R", I can explain the root of the issue here. Basically most machine learning libraries that follow the pattern of "implement in something low-level then write APIs in Python and R" have native code in R or Python calling the low-level code. So e.g. for RGF is different in that it does that in Python and then uses an R package called This is bad in the sense that you need to have a full Python setup to run the R stuff, but it's good in the sense that development can focus almost exclusively on the Python side and making the R package work only means ensuring it plays nicely with Python. |
@jameslamb Totally agree with you! I can say even more: here, in this part |
"if you agree I can create an issue for this and try to address it." I'm ok with this, you can proceed. |
@jameslamb Hi! Just letting you know that the code coverage of R-package is now checked at the CI side with a 50%-threshold. |
@StrikerRUS hey awesome! |
|
@mlampros Ah, I see. I think, in Python we test only rgf/python-package/tests/test_rgf_python.py Lines 67 to 75 in 44b3654
I guess tests for Sure, any time you can! Thank you very much! |
After #267 has been merged, it can be easily observed which pieces of code are uncovered:
@mlampros @jameslamb Guys, may I ask you for your help?
The text was updated successfully, but these errors were encountered: