Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I updated the R-package to CRAN version 1.0.6 #277

Merged
merged 2 commits into from
Jan 30, 2019
Merged

I updated the R-package to CRAN version 1.0.6 #277

merged 2 commits into from
Jan 30, 2019

Conversation

mlampros
Copy link
Collaborator

The R-package was updated to CRAN version 1.0.6. It might take a couple of days for the Windows and OS X binaries to be built.

@mlampros mlampros mentioned this pull request Jan 15, 2019
Closed
@StrikerRUS
Copy link
Member

Are these changes from this PR in 1.0.6 at CRAN?

R is unhappy with versioning again :-(. I suppose you can update to 1.0.6.1 here to avoid the warning.

@mlampros
Copy link
Collaborator Author

mlampros commented Jan 15, 2019 •
edited
Loading

I'm sorry, I forgot that I had to adjust the version to 4-digits. Now, it should pass the .travis checks.

@mlampros
Copy link
Collaborator Author

the .travis-linux is ok, however the .travis-OS X gives a WARNING. I don't know if it's related with the fact that libgit2 is not installed,

configure: error: 
  ---------------------------------------------
   The libgit2 library that is required to build git2r was not found.
  ......
   libgit2       (Homebrew package on macOS)

or with the pandoc version in Anaconda (as indicated here and here),

Could not fetch https://r-pkg.org/badges/version/RGF
.........

@StrikerRUS
Copy link
Member

@mlampros No problem! Thank you!
I've re-run the failed job. Let's see...

@StrikerRUS
Copy link
Member

Seems it was accidental download error... Travis is happy now.

@StrikerRUS
Copy link
Member

StrikerRUS commented Jan 15, 2019 •
edited
Loading

For auto-closing the issue: closed #276

@StrikerRUS StrikerRUS requested review from fukatani and removed request for fukatani January 18, 2019 14:14
@StrikerRUS StrikerRUS mentioned this pull request Jan 18, 2019
Merged
@StrikerRUS
Copy link
Member

ping @fukatani for the review

@StrikerRUS
Copy link
Member

@fukatani Can you please review this PR because it blocks all others.

@fukatani
Copy link
Member

Ah.. really sorry.
I was not aware of this PR.

fukatani
fukatani approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlampros mlampros merged commit 90f327a into master Jan 30, 2019
@StrikerRUS StrikerRUS deleted the CRAN-version-1_0_6 branch January 30, 2019 17:25
@StrikerRUS
Copy link
Member

Thanks, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fukatani fukatani fukatani approved these changes

@StrikerRUS StrikerRUS StrikerRUS approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlampros @StrikerRUS @fukatani