Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests to increase R code coverage for sparse matrices #311

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

StrikerRUS
Copy link
Member

81% -> 88%.

Related to #269.

@mlampros
Copy link
Collaborator

@StrikerRUS,

lately I search for classifiers (xgboost, catboost, ligthgbm) and I saw that both you and jameslamb are very active in the lightgbm repository.

Thanks for adding the tests, last week I came across the following blog post which explains the differences between class(), inherits() and is() in R. Just a comment as I saw you've used class in the added tests.

@StrikerRUS
Copy link
Member Author

@mlampros Thank you very much for your review and the link! These new tests are copy-pasted existing ones with slight modifications for another sparse type (the biggest change is adding as(matrix, "RsparseMatrix") to test the dgRMatrix class).

@StrikerRUS StrikerRUS merged commit 7eba2e5 into master Nov 19, 2019
@StrikerRUS
Copy link
Member Author

@jameslamb You may be interested in that blog post 🙂 .

@StrikerRUS StrikerRUS deleted the r_cover branch November 19, 2019 21:00
@jameslamb
Copy link
Contributor

@jameslamb You may be interested in that blog post 🙂 .

loved it! I have known bits and pieces of this but it's a nice, concise description in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants