Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification for FCS3.2 Compatibility #263

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

Newlyn01
Copy link
Contributor

This pull request adresses the need for compatibility with FCS3.2 data.
The following changes have been made:

  • in R/IO.R line 17: Added "FCS3.2" as possible version
  • in R/IO.R lines 671-672: Added "FCS3.2" as possible version + updated the stopmessage

@gfinak
Copy link
Member

gfinak commented Jan 10, 2024

Please do not check in .o object files.

@mikejiang
Copy link
Member

The actual FCS3.2 support is yet to be implemented

@SofieVG
Copy link

SofieVG commented Jan 11, 2024

While the implementation of additional support for FCS3.2 would be much appreciated, we found it already useful to have this in-between fix just so we can read in the fcs files and access the numeric values in R, which otherwise is not possible at all. As we thought this might be helpful for others as well, we thought a pull request might be appropriate. Maybe we can still add a warning for FCS3.2 stating it is not fully supported yet, rather than having it stop on the error completely?

@Newlyn01
Copy link
Contributor Author

I have reverted the commit where .o files got pushed. I have now also added a warning message saying that FCS3.2 is not fully supported yet by the flowCore package. This warning will only be returned when an FCS3.2 file is read.

@gfinak
Copy link
Member

gfinak commented Jan 18, 2024

@mikejiang I'm okay with this change, feel free to merge.

@mikejiang mikejiang merged commit b098223 into RGLab:devel Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants