Skip to content

Commit

Permalink
tests/sx127x: deduce size of netopts from variable
Browse files Browse the repository at this point in the history
This adapts automatically when a variable type changes, which is easy
to forget to change the correspondig netdev->set/get call.
  • Loading branch information
daniel-k committed Jan 5, 2018
1 parent 0ee2bbe commit f95463a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tests/driver_sx127x/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,11 @@ int lora_setup_cmd(int argc, char **argv) {
/* Configure radio device */
netdev_t *netdev = (netdev_t*) &sx127x;
netdev->driver->set(netdev, NETOPT_BANDWIDTH,
&lora_bw, sizeof(uint8_t));
&lora_bw, sizeof(lora_bw));
netdev->driver->set(netdev, NETOPT_SPREADING_FACTOR,
&lora_sf, 1);
&lora_sf, lora_sf);
netdev->driver->set(netdev, NETOPT_CODING_RATE,
&lora_cr, sizeof(uint8_t));
&lora_cr, sizeof(lora_cr));

puts("[Info] setup: configuration set with success");

Expand Down Expand Up @@ -247,7 +247,7 @@ int listen_cmd(int argc, char **argv)

/* Switch to RX state */
uint8_t state = NETOPT_STATE_RX;
netdev->driver->set(netdev, NETOPT_STATE, &state, sizeof(uint8_t));
netdev->driver->set(netdev, NETOPT_STATE, &state, sizeof(state));

printf("Listen mode set\n");

Expand All @@ -263,7 +263,7 @@ int channel_cmd(int argc, char **argv)

uint32_t chan;
if (strstr(argv[1], "get") != NULL) {
netdev->driver->get(netdev, NETOPT_CHANNEL_FREQUENCY, &chan, sizeof(uint32_t));
netdev->driver->get(netdev, NETOPT_CHANNEL_FREQUENCY, &chan, sizeof(chan));
printf("Channel: %i\n", (int) chan);
return 0;
}
Expand All @@ -274,7 +274,7 @@ int channel_cmd(int argc, char **argv)
return -1;
}
chan = atoi(argv[2]);
netdev->driver->set(netdev, NETOPT_CHANNEL_FREQUENCY, &chan, sizeof(uint32_t));
netdev->driver->set(netdev, NETOPT_CHANNEL_FREQUENCY, &chan, sizeof(chan));
printf("New channel set\n");
}
else {
Expand Down

0 comments on commit f95463a

Please sign in to comment.