Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race condition in vtimer_sleep #550

Closed
LudwigKnuepfer opened this issue Jan 23, 2014 · 1 comment · Fixed by #551
Closed

race condition in vtimer_sleep #550

LudwigKnuepfer opened this issue Jan 23, 2014 · 1 comment · Fixed by #551
Labels
Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@LudwigKnuepfer
Copy link
Member

When the period in vtimer_sleep is to small, the thread gets woken up before it goes to sleep. Therefore, when it goes to sleeps forever.
@OlegHahm
Copy link
Member

That seems to be the same problem as in #25. Replacing the implementation based on thread_sleep() by something based on mutex_lock() (as in current hwtimer_wait()) could solve the problem here, too.

jpfender pushed a commit to jpfender/riot-gossip that referenced this issue Jan 23, 2014
main: Fix vtimer_sleep race condition, with help from Ludwig
36672f7 
See RIOT-OS/RIOT#550
@mehlis mehlis mentioned this issue Jan 23, 2014
Merged
kaspar030 pushed a commit to kaspar030/RIOT that referenced this issue Feb 12, 2014
@kaspar030
use mutex in vtimer_sleep
5b0e97f 
this change prevents a race condition in case of
short sleep time

Fixes: RIOT-OS#550
kaspar030 pushed a commit to kaspar030/RIOT that referenced this issue Apr 3, 2014
@kaspar030
use mutex in vtimer_sleep
e2f7ec9 
this change prevents a race condition in case of
short sleep time

Fixes: RIOT-OS#550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use mutex in vtimer_sleep
2 participants
@OlegHahm @LudwigKnuepfer