Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2018.10 notes #10257

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Release 2018.10 notes #10257

merged 1 commit into from
Nov 13, 2018

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Oct 25, 2018

Contribution description

This is the draft PR for the 2018.10 release note (follow up of @cladmi's idea to do it in a PR :)

I invite maintainers to push directly to my branch to document major changes that are not yet listed.
Developers can comment here to add their work.

As a reference, I tried to list all merged PRs in master and closed issues for this release in https://github.com/RIOT-OS/RIOT/milestone/24?closed=1.
It will be again updated with time.

Issues/PRs references

Release 2018.10

aabadie
aabadie reviewed Oct 26, 2018
View reviewed changes
release-notes.txt Outdated
LTO
#5848: arduino: Race condition in sys/arduino/Makefile.include
#6018: nRF52: gnrc 6lowpan ble memory leak
#6437: periph/spi: Leftovers from SPI rework in #4780
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue can be removed since it is closed now. Maybe it should just be moved to the solved issues.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! I will re-check the list now

aabadie
aabadie requested changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't verified in details but the list of issues needs an update.

release-notes.txt Outdated Show resolved Hide resolved
release-notes.txt Outdated Show resolved Hide resolved
@jia200x
Copy link
Member Author

jia200x commented Nov 6, 2018

thank you so much @aabadie!!

@jia200x jia200x changed the title Release 2018.10 notes [WIP] Release 2018.10 notes Nov 6, 2018
miri64
miri64 reviewed Nov 6, 2018
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly note to self. I will provide a commit to add those to the notes.

release-notes.txt Outdated Show resolved Hide resolved
release-notes.txt Outdated Show resolved Hide resolved
release-notes.txt Outdated Show resolved Hide resolved
release-notes.txt Show resolved Hide resolved
release-notes.txt Show resolved Hide resolved
release-notes.txt Show resolved Hide resolved
@jia200x
Copy link
Member Author

jia200x commented Nov 7, 2018

btw this gist contains all PRs between 2018.07-RC2 (Release) and 2018.10-RC2. I tagged them with their "Type: " label in the beggining, so it's easy to filter them using grep ;)

@cladmi
Copy link
Contributor

cladmi commented Nov 7, 2018

@jia200x Why not just using https://github.com/RIOT-OS/RIOT/milestone/24 ?

@jia200x
Copy link
Member Author

jia200x commented Nov 7, 2018

@jia200x Why not just using https://github.com/RIOT-OS/RIOT/milestone/24 ?

Because I can copy them directly from the grep'd/sed'd file to the release-notes :)

@cladmi
Copy link
Contributor

cladmi commented Nov 7, 2018

I found that the milestone was outdated, I updated my PRs to be listed in the milestone at least.

@jia200x
Copy link
Member Author

jia200x commented Nov 7, 2018

I found that the milestone was outdated, I updated my PRs to be listed in the milestone at least.

Thank you! Yeah, that's also why I got it from the commits. I was afraid it might be not synced properly in some cases

@cladmi
Copy link
Contributor

cladmi commented Nov 7, 2018

I added my contributions after the others in the list.

I was afraid it might be not synced properly in some cases

It is better if it can be updated for the release ;)
To update it during the previous release I used this page https://github.com/RIOT-OS/RIOT/pulls?q=is%3Amerged+no%3Amilestone

I also used it this time to find my unasigned PRs.

danpetry
danpetry reviewed Nov 9, 2018
View reviewed changes
release-notes.txt Outdated Show resolved Hide resolved
jia200x
jia200x commented Nov 9, 2018
View reviewed changes
release-notes.txt Outdated
* semtech-loramac: use periph_eeprom to store lorawan configuration
* semtech-loramac: add support for RU864 ISM band
* semtech-loramac: lorawan support is not considered experimental anymore
* semtech-loramac: reduce timeout in timer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aabadie I will remove this was a revert of a change introduced by the semtech_loramac bump during the release ;)

jia200x
jia200x commented Nov 9, 2018
View reviewed changes
release-notes.txt Outdated
@@ -80,6 +84,7 @@ Boards
+ add support for ublox-c030-u201
+ add i2c configuration for nucleo-f070, nucleo-f091rc and nucleo-f722ze
+ add second i2c configuration for b-l475e-iot01a
+ add PWM support for NRF52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aabadie I moved this one to CPU

@cladmi
Copy link
Contributor

cladmi commented Nov 12, 2018 •
edited
Loading

I added #10377 to the release notes as it should still go in.

@cladmi
Copy link
Contributor

cladmi commented Nov 12, 2018

Also added #10374 that I just merged.

@jia200x jia200x changed the title [WIP] Release 2018.10 notes Release 2018.10 notes Nov 12, 2018
MrKevinWeiss
MrKevinWeiss reviewed Nov 13, 2018
View reviewed changes
release-notes.txt Outdated
* makefiles/buildtests.inc.mk: fix 'clean-intermediates' not cleaning
* makefiles/docker.inc.mk: handle building in git worktree
* openocd.sh: allow flashing binary files without configuration
* pkg.mk: do not use user identidy when applying patches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identidy -> identity

release-notes.txt Outdated
#6836: Issuing a reboot on ATmega328p makes the board loop-reboot
#7846: stm32f1: I2C read functions return bogus values with unconnected devices
#9616: at86rf2xx: can not correctly set channel after `NETOPT_STATE_RESET`
#9548: Many i2c bugs found with the i2c api rework but did not reach the release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in both known and fixed issue (I guess certain aspects were fixed and some remain?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifically this line:
#9548: Many i2c bugs found with the i2c api rework but did not reach the release

@miri64 miri64 added the Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) label Nov 13, 2018
@jia200x
Copy link
Member Author

jia200x commented Nov 13, 2018

wrote a script for last checks using the Github API. It turns out some of the fixed issues were still in the Know Issues part. So, I removed these stuff in the last commit ;)

@jia200x
Copy link
Member Author

jia200x commented Nov 13, 2018

(I will release these helpers when I find some time)

@jia200x
Copy link
Member Author

jia200x commented Nov 13, 2018

@aabadie are you ok with the changes?

@miri64
Copy link
Member

miri64 commented Nov 13, 2018

It turns out some of the fixed issues were still in the Know Issues part. So, I removed these stuff in the last commit ;)

They should be moved to fixed issues then ;-)

@jia200x
Copy link
Member Author

jia200x commented Nov 13, 2018

They should be moved to fixed issues then ;-)

They are already there, they were duplicated :)

@miri64
Copy link
Member

miri64 commented Nov 13, 2018

Ah okay. The commit did (of course) did not show that, so I did not know.

@jia200x
Copy link
Member Author

jia200x commented Nov 13, 2018

@RIOT-OS/maintainers last call :)

If the document is ok please ACK :)

aabadie
aabadie reviewed Nov 13, 2018
View reviewed changes
release-notes.txt Outdated Show resolved Hide resolved
aabadie
aabadie reviewed Nov 13, 2018
View reviewed changes
release-notes.txt Outdated Show resolved Hide resolved
@jia200x
Copy link
Member Author

jia200x commented Nov 13, 2018

@aabadie done. I will squash now

@jia200x jia200x force-pushed the pr/release_notes_2018.10 branch 2 times, most recently from ed6609d to 344f7d0 Compare November 13, 2018 12:07
@jia200x jia200x added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 13, 2018
leandrolanzieri
leandrolanzieri approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all comments were addressed. ACK.

@danpetry
Copy link
Contributor

I read over the boilerplate and intro and all looks good, grammar-wise. ACK

@jia200x jia200x merged commit 8de5ba2 into RIOT-OS:master Nov 13, 2018
@jia200x jia200x mentioned this pull request Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 left review comments

@aabadie aabadie aabadie approved these changes

@MrKevinWeiss MrKevinWeiss MrKevinWeiss left review comments

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@danpetry danpetry danpetry approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jia200x @cladmi @miri64 @danpetry @aabadie @leandrolanzieri @MrKevinWeiss