-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add driver for SDS011 active laser dust sensor #10458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first sweep, looks nice already - only minor coding style issues, check position of braces!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. Just a few comments, most of them typos.
@smlng @leandrolanzieri thank you for reviewing! I think all requests should be addressed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments have been addressed. I ran the test and works as expected. Looks good to me.
@smlng ping? |
a1bf51f
to
34ce2be
Compare
@smlng ping |
34ce2be
to
c3d183e
Compare
c3d183e
to
ed56dd3
Compare
rebased again @smlng ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the documentation many functions have a preconditions like <param> != NULL
, for these there should be a matching assert in every implementation to verify this during development. This is missing, e.g. in sds011_get_fw_version
and others.
@smlng everything addressed now? and may I squash? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good except one small inconsistency 😬 Please amend directly and squash previous changes as needed, too.
fdc15bd
to
8a5f110
Compare
044620a
to
bba4d5b
Compare
@smlng I fixed the remaining problems reported by murdock and removed the separate thread in the test to make it fit on the small arduinos. So, finally all spaces where they should be?^^ |
Contribution description
Adds a driver and SAUL integration for the SDS011 dust sensor for measuring particulate matter concentration.
Testing procedure
Below example is only true for
pba-d-01-kw2x
, for other boards adapt as needed.For SAUL use the default test application:
With the provided test:
Issues/PRs references