pyterm: use python3 by default #10992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3 has been the default in our scripts for some time now, but pyterm still requested python which uses python2 on ubuntu stable. This pushes toward only needing to install `python3` python dependencies.
cladmi
added
Type: enhancement
19 tasks
cladmi
added
the
CI: ready for build
|
I think this is OK, in fact, in my system python==python3, so I was already using pyterm with python3 anyways. Just in case, though, I'd wait to see it it is working for others too before we merge. |
|
I ran the test suite with |
jcarrano
approved these changes
Feb 12, 2019
|
Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Python3 has been the default in our scripts for some time now, but pyterm still
requested python which uses python2 on ubuntu stable.
This pushes toward only needing to install
python3pythondependencies.
Testing procedure
If you are using a distribution where
python == python3by default, it should not change anything.Running tests with
murdockhere should not help as tests are not run withpytermI think.Running
make termandmake testwith boards usingpytermshould still work by default:Then testing
make terminexamples/defaultfor example and running the tests should work the same as without this pull request.Vagrant
The vagrant image already installs
python3-serialbut would be nice to verify too.make termon a board.Issues/PRs references
Found while testing on a machine where only
python3dependencies were installed.#10870