Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/hts211: fix CTRL_REG2_OS_EN #11017

Merged
merged 1 commit into from
Feb 14, 2019
Merged

drivers/hts211: fix CTRL_REG2_OS_EN #11017

merged 1 commit into from
Feb 14, 2019

Conversation

smlng
Copy link
Member

@smlng smlng commented Feb 14, 2019

Contribution description

fixes #11013

Testing procedure

compile and test the sensor, should still work.

Issues/PRs references

#11013

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 14, 2019
@smlng smlng self-assigned this Feb 14, 2019
@smlng
Copy link
Member Author

smlng commented Feb 14, 2019

also see datasheet pages 22/33

@smlng smlng mentioned this pull request Feb 14, 2019
Closed
aabadie
aabadie approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the datasheet and this PR obviously fixes the one shot bit position in CTRL_REG2 register.

I also tested the driver and it works.

ACK and go

@aabadie aabadie merged commit 9fd6a50 into RIOT-OS:master Feb 14, 2019
@smlng
Copy link
Member Author

smlng commented Feb 15, 2019

thx @aabadie for handling this quickly 😄

@smlng smlng deleted the fix/drivers/hts211 branch February 15, 2019 09:58
@aabadie aabadie added this to the Release 2019.04 milestone Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

@smlng smlng

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.

hts221: wrong bit for "one-shot enable" register
2 participants
@smlng @aabadie