Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/semtech-loramac: fixing missing directive in doc #11042

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 21, 2019

Contribution description

Setting the LORAMAC_ACTIVE_REGION define via cflags is required for building any lorawan application. The doxygen documentation is missing this define.

Testing procedure

Read and follow the documentation to write your own lorawan application. You can compare to examples/lorawan and tests/pkg_semtech-loramac applications' Makefiles.

Issues/PRs references

Loosely related to #8864

Setting the LORAMAC_ACTIVE_REGION define via cflags is required for any lorawan application to build
@aabadie aabadie added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: LoRa Area: LoRa radio support labels Feb 21, 2019
@aabadie aabadie requested a review from jia200x February 21, 2019 07:36
@jia200x
Copy link
Member

jia200x commented Feb 21, 2019

@yegorich was having this issue. Thanks for the doc fix!

Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x jia200x merged commit d4f0864 into RIOT-OS:master Feb 21, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
@aabadie aabadie deleted the pr/pkg/semtech-loramac_doc_fix branch July 4, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants