pkg/nimble: optimize package initialization #11131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Type: enhancement
miri64
reviewed
Mar 7, 2019
| bluetil_ad_t ad; | ||
| bluetil_ad_init_with_flags(&ad, buf, sizeof(buf), BLUETIL_AD_FLAGS_DEFAULT); | ||
| bluetil_ad_add_name(&ad, device_name); | ||
| ble_gap_adv_set_data(ad.buf, ad.pos); |
There was a problem hiding this comment.
Could you please add a comment to the commit why you unrolled this function.
miri64
added
Reviewed: 1-fundamentals
|
Tested ACK. We can merge if you at least acknowledge my comment ;-) |
This static function was a leftover from very early stages of this example and at the current state there is not sense in keeping it. Having these few lines directly where the advertising is triggered makes the code more clean and readible.
haukepetersen
force-pushed
the
opt_nimble_initialization
branch
from
35a56a3
to
4e49fa5
Compare
|
put the justification in the commit message. |
miri64
added
the
Reviewed: 5-documentation
|
all green, lets go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Some typical initialization steps for nimBLE need to be (re-)written for any application, so it makes sense to put them in the shared initialization code path to prevent (future) code duplication. I have a couple of additional example applications that I am preparing (mostly around ICN and IPv6 over BLE), and all of these will benefit from these proposed changes.
This PR collects some generic initialization artifacts and places them in the global init function. It then removes these lines from the
nimble_gattexample.Testing procedure
Run the
examples/nimble_gattexample an verify that all services are still working.Issues/PRs references
none