Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/edbg: Update to latest version. #11156

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Conversation

jcarrano
Copy link
Contributor

@jcarrano jcarrano commented Mar 11, 2019

Contribution description

The lastest version of edbg solves a double-reset issue that was hindering testing (see #11125 and ataradov/edbg#77)

It also adds support for SAMR34 and SAMR35, needed by @dylad for MCU port (that's why it has both the "bug" and "feature" labels.)

Testing procedure

Without #11129 the package won't be updated unless the edbg binary and the repo are deleted. (Edit: #11129 is in).

# EDIT: This is not needed anymore
$ rm -rf dist/tools/edbg/edbg dist/tools/edbg/bin

Proceed to flash and reset any atmel board.

$ BOARD=samr21-xpro make -C examples/hello-world all flash
$ BOARD=samr21-xpro make -C examples/hello-world reset

Issues/PRs references

Fixes: #11125.
Would be nice to have #11129 before so that users get the update automatically.
I'm finding hard to test #11099 without this (double resets cause failures unrelated to the change).

The lastest version of edbg solves a double-reset issue that was
hindering testing (see RIOT-OS#11125 and ataradov/edbg#77)

It also adds support for SAMR34 and SAMR35, needed by @dylad for MCU
port.
@jcarrano jcarrano added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: tools Area: Supplementary tools labels Mar 11, 2019
@jcarrano jcarrano requested a review from dylad March 11, 2019 15:05
@dylad dylad added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Mar 13, 2019
@dylad
Copy link
Member

dylad commented Mar 13, 2019

I'll test it right after #11129 is merged and I'll PR the SAMR34-XPRO board !

@dylad dylad self-assigned this Mar 17, 2019
@jcarrano jcarrano added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 19, 2019
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.
tested on SAML21-XPRO and SAML11-XPRO. They still work as expected.

@dylad dylad added Reviewed: 3-testing The PR was tested according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 19, 2019
@dylad dylad merged commit c99c0f6 into RIOT-OS:master Mar 19, 2019
@danpetry danpetry added this to the Release 2019.04 milestone Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants