Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: add support for im880b lora board #11315

Merged
merged 3 commits into from
Mar 13, 2020
Merged

boards: add support for im880b lora board #11315

merged 3 commits into from
Mar 13, 2020

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Mar 29, 2019 •
edited
Loading

Contribution description

This PR adds im880b board, this board has a stm32l152cb microcontroler and a sx1272 radio.

Testing procedure

Run all tests:
python dist/tools/compile_and_test_for_board/compile_and_test_for_board.py --jobs 0 ..RIOT im880b

Manually test:
Compile and test the loramac test application.
make BOARD=im880b LORA_DRIVER=sx1272-C tests/pkg_semtech-loramac clean all -j flash

Issues/PRs references

Depends on: #11314 & #11316

This was referenced Mar 29, 2019
Merged
Merged
@aabadie aabadie added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: LoRa Area: LoRa radio support Area: boards Area: Board ports labels Mar 29, 2019
@aabadie aabadie self-requested a review March 29, 2019 20:22
@aabadie aabadie changed the title Pr im880b boards: add support for im880b lora board Mar 29, 2019
@kYc0o
Copy link
Contributor

kYc0o commented Apr 2, 2019

Can you check if this board applies for code reusage based on the lobaro-lorabox board?

@aabadie aabadie mentioned this pull request May 9, 2019
Merged
This was referenced Jul 16, 2019
Merged
Merged
@stale
Copy link

stale bot commented Jan 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jan 17, 2020
@kYc0o
Copy link
Contributor

kYc0o commented Jan 17, 2020

Well actually I got one of these and I'm able to test. Will check the code soon.

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Jan 17, 2020
@kYc0o
Copy link
Contributor

kYc0o commented Jan 17, 2020

Please rebase if possible.

@kYc0o
Copy link
Contributor

kYc0o commented Jan 17, 2020

Just tested it. Works as expected.

I just didn't test the flashing since it seems to flash the same way as the Lobaro board.

kYc0o
kYc0o approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

aabadie
aabadie requested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase and some other things should be changed because the build system has changed in the meantime.
I found a couple of typos here and there.

boards/im880b/Makefile.features Outdated Show resolved Hide resolved
boards/im880b/Makefile.features Show resolved Hide resolved
boards/im880b/Makefile.include Outdated Show resolved Hide resolved
boards/im880b/Makefile.include Outdated Show resolved Hide resolved
boards/im880b/doc.txt Outdated Show resolved Hide resolved
boards/im880b/doc.txt Outdated Show resolved Hide resolved
boards/im880b/doc.txt Show resolved Hide resolved
boards/im880b/include/board.h Outdated Show resolved Hide resolved
boards/im880b/include/board.h Outdated Show resolved Hide resolved
boards/im880b/include/gpio_params.h Outdated Show resolved Hide resolved
@fjmolinas
Copy link
Contributor Author

Rebased and comments addressed

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 23, 2020
@fjmolinas
Copy link
Contributor Author

There might be other stuff that is not standard anymore, will trigger a build to check.

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 5, 2020
@benpicco
Copy link
Contributor

benpicco commented Feb 5, 2020

Some new tests were added that don't fit on the board.

@benpicco benpicco requested a review from aabadie February 6, 2020 20:08
@fjmolinas
Copy link
Contributor Author

Everything is passing now, @kYc0o @aabadie can I squash?

@fjmolinas
Copy link
Contributor Author

@aabadie can I squash when rebasing?

@aabadie
Copy link
Contributor

aabadie commented Mar 10, 2020

can I squash when rebasing?

Yes please

@fjmolinas fjmolinas force-pushed the pr_im880b branch 2 times, most recently from f85c503 to 161dab0 Compare March 10, 2020 10:43
@aabadie
Copy link
Contributor

aabadie commented Mar 10, 2020 •
edited
Loading

nit: there's a typo in 161dab0: s/memmory/memory

@fjmolinas
Copy link
Contributor Author

FIxed typo and ammended insufficient memmory list

@aabadie
Copy link
Contributor

aabadie commented Mar 10, 2020

FIxed typo and ammended insufficient memmory list

Do you mean memory (and amended) ? 😆

@benpicco
Copy link
Contributor

@aabadie have your comments been addressed? 😉

aabadie
aabadie approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go!

@aabadie aabadie merged commit c974451 into RIOT-OS:master Mar 13, 2020
@fjmolinas fjmolinas deleted the pr_im880b branch March 13, 2020 14:07
@fjmolinas
Copy link
Contributor Author

Thanks for the review!

@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@kYc0o kYc0o kYc0o approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
5 participants
@fjmolinas @kYc0o @benpicco @aabadie @leandrolanzieri