Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nrf52840-mdk: added I2C config #11513

Merged
merged 1 commit into from
Jun 11, 2019
Merged

boards/nrf52840-mdk: added I2C config #11513

merged 1 commit into from
Jun 11, 2019

Conversation

skullbox305
Copy link
Contributor

@skullbox305 skullbox305 commented May 13, 2019 •
edited
Loading

Contribution description

Added a I2C config for the nrf52840-mdk. The pins correspond to the first Grove port of the Base Dock (See)

Testing procedure

run tests/driver_bmx280 or any other i2c device with this board

Issues/PRs references

None

@MrKevinWeiss MrKevinWeiss added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 28, 2019
@MrKevinWeiss
Copy link
Contributor

MrKevinWeiss commented May 28, 2019 •
edited
Loading

It looks good but I don't have the board. Can someone else test and confirm?

@aabadie
Copy link
Contributor

aabadie commented May 28, 2019

Can someone else test and confirm?

I have the board but no sensor (until next week) unfortunately. I put this on my todo list. Don't hesitate to ping me if you think I'll forget ;)

@MrKevinWeiss
Copy link
Contributor

Will do 😉

@MrKevinWeiss
Copy link
Contributor

@aabadie ping

@MrKevinWeiss MrKevinWeiss added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 3, 2019
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 11, 2019
aabadie
aabadie approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, tested with a sensor and it works! ACK
(I retriggered Murdock, just in case)

@aabadie
Copy link
Contributor

aabadie commented Jun 11, 2019

Thanks @skullbox305! Let's go.

@aabadie aabadie merged commit 4e5a320 into RIOT-OS:master Jun 11, 2019
@aabadie aabadie mentioned this pull request Jun 11, 2019
Merged
@maribu maribu mentioned this pull request Jun 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullbox305 @MrKevinWeiss @aabadie