Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/atmega*/ldscripts_compat: add command to generate ldscript #11615

Merged
merged 1 commit into from
Jun 3, 2019
Merged

cpu/atmega*/ldscripts_compat: add command to generate ldscript #11615

merged 1 commit into from
Jun 3, 2019

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 3, 2019

Contribution description

Add the command to generate the ldscript in the documentation.
It was only in the commit message before.

Testing procedure

Same as in the commit message:

git show --stat  56a1ac4f2 
commit 56a1ac4f2b158cb6859d09a9e73754d76699e5cf
Author: Gaëtan Harter <gaetan.harter@fu-berlin.de>
Date:   Wed Aug 15 14:18:01 2018 +0200

    cpu/atmega: add avr-binutils 2.26 linkerscripts
    
    Generated by extracting the output of
    
        avr-gcc -Wl,--verbose --mmcu=$(CPU)
    
    With avr-binutils 2.26

 cpu/atmega1281/ldscripts_compat/README.md      |   8 +++++++
 cpu/atmega1281/ldscripts_compat/avr_2.26.ld    | 262 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 cpu/atmega1284p/ldscripts_compat/README.md     |   8 +++++++
 cpu/atmega1284p/ldscripts_compat/avr_2.26.ld   | 262 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 cpu/atmega2560/ldscripts_compat/README.md      |   8 +++++++
 cpu/atmega2560/ldscripts_compat/avr_2.26.ld    | 262 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 cpu/atmega256rfr2/ldscripts_compat/README.md   |   8 +++++++
 cpu/atmega256rfr2/ldscripts_compat/avr_2.26.ld | 262 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 cpu/atmega328p/ldscripts_compat/README.md      |   8 +++++++
 cpu/atmega328p/ldscripts_compat/avr_2.26.ld    | 262 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 10 files changed, 1350 insertions(+)

Issues/PRs references

It was unclear which lead to #11537 and another mention I do not find anymore

The files were introduced in #9781

@cladmi cladmi added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: doc Area: Documentation Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Jun 3, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 3, 2019
@cladmi cladmi requested a review from smlng June 3, 2019 08:40
@cladmi cladmi mentioned this pull request Jun 3, 2019
Closed
@cladmi
Copy link
Contributor Author

cladmi commented Jun 3, 2019

@benpicco is this good for you ? it is important that the documentation helps you.

@benpicco
Copy link
Contributor

benpicco commented Jun 3, 2019

Yes this sure helps explains where that file comes from.

smlng
smlng suggested changes Jun 3, 2019
View reviewed changes
cpu/atmega1281/ldscripts_compat/README.md Outdated

Generated by extracting the output of

avr-gcc -Wl,--verbose --mmcu=$(CPU)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an error for this command, need to use -mmcu instead of --mmcu (no double dashes)

what I ran is

avr-gcc -Wl,--verbose -mmcu=atmega1281

I have avr-binutils 2.32 and avr-gcc 8.3.0 (on macOS installed via brew)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, was a mistake in the commit message too now that I remember.
My bad for not re-testing…

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is bad to rush these changes ><

smlng
smlng approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash

@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 3, 2019
@smlng smlng self-assigned this Jun 3, 2019
@smlng
Copy link
Member

smlng commented Jun 3, 2019

and trigger CI afterwards, THX!

@cladmi cladmi force-pushed the pr/cpu/atmega_common/ldscripts_compat/doc branch from b18f23e to ba91b61 Compare June 3, 2019 13:31
@cladmi cladmi added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 3, 2019
@cladmi
cpu/atmega*/ldscripts_compat: add command to generate ldscript
40e7dd3 
Add the command to generate the ldscript in the documentation.
It was only in the commit message before and had a typo 's/--mmcu/-mmcu/'.
@cladmi cladmi force-pushed the pr/cpu/atmega_common/ldscripts_compat/doc branch from ba91b61 to 40e7dd3 Compare June 3, 2019 14:11
@cladmi
Copy link
Contributor Author

cladmi commented Jun 3, 2019

And typo again in the commit message >< Now it should be good.

@cladmi
Copy link
Contributor Author

cladmi commented Jun 3, 2019

CI and everybody is happy.

@cladmi cladmi merged commit fcd7f22 into RIOT-OS:master Jun 3, 2019
@cladmi cladmi deleted the pr/cpu/atmega_common/ldscripts_compat/doc branch June 3, 2019 14:50
miri64 added a commit to miri64/RIOT that referenced this pull request Jun 5, 2019
@miri64
fixup! Merge pull request RIOT-OS#11615 from cladmi/pr/cpu/atmega_com…
e3762fc 
…mon/ldscripts_compat/doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

Assignees

@smlng smlng

Labels
Area: build system Area: Build system Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.07
Development

Successfully merging this pull request may close these issues.
3 participants
@cladmi @benpicco @smlng