Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usbdev feature to Sodaq boards #11639

Merged
merged 4 commits into from
Jun 6, 2019
Merged

Add usbdev feature to Sodaq boards #11639

merged 4 commits into from
Jun 6, 2019

Conversation

keestux
Copy link
Contributor

@keestux keestux commented Jun 5, 2019

These SODAQ boards all have a USB and have a SAMD21 (like Arduino Zero). I didn't realize that #10915 was already merged, otherwise it would have made sense to have this done at the same time.

I haven't looked at other boards with SAMD21. Maybe somebody else should, because I only have these SODAQ boards.

@aabadie aabadie added Area: boards Area: Board ports Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 6, 2019
@aabadie aabadie self-requested a review June 6, 2019 07:47
@aabadie
Copy link
Contributor

aabadie commented Jun 6, 2019

I will test on sodaq-autonomo and explorer. I don't have the other boards.

@aabadie
Copy link
Contributor

aabadie commented Jun 6, 2019

Works on sodaq-autonomo:

[mer. juin  5 12:48:11 2019] usb 2-3.2: New USB device found, idVendor=1209, idProduct=0001, bcdDevice= 0.00
[mer. juin  5 12:48:11 2019] usb 2-3.2: New USB device strings: Mfr=3, Product=2, SerialNumber=0
[mer. juin  5 12:48:11 2019] usb 2-3.2: Product: USB device
[mer. juin  5 12:48:11 2019] usb 2-3.2: Manufacturer: RIOT-os.org

aabadie
aabadie approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good (and maybe one day they could be factorized).

Tested and it works.

ACK

@aabadie aabadie merged commit a07be83 into RIOT-OS:master Jun 6, 2019
@dylad dylad added this to the Release 2019.07 milestone Jun 6, 2019
This was referenced Jun 6, 2019
Merged
Merged
@keestux keestux deleted the add-usb-sodaq-boards branch June 6, 2019 18:21
@MrKevinWeiss MrKevinWeiss added Type: new feature The issue requests / The PR implemements a new feature for RIOT Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2019.07
Development

Successfully merging this pull request may close these issues.
4 participants
@keestux @aabadie @MrKevinWeiss @dylad