Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nucleo-l476rg: add riotboot #11643

Merged
merged 3 commits into from
Jun 14, 2019
Merged

boards/nucleo-l476rg: add riotboot #11643

merged 3 commits into from
Jun 14, 2019

Conversation

fjmolinas
Copy link
Contributor

Contribution description

This PR adds riotboot support or nucleo-l476rg. It should work for all nucleo stm32l4 based boards.

Testing procedure

Run riotboot tests and everything should work as expected.

BOARD=nucleo-l476rg FEATURES_REQUIRED+=riotboot make -C tests/xtimer_usleep riotboot/flash-extended-slot0 term

BOARD=nucleo-l476rg FEATURES_REQUIRED+=riotboot make -C tests/xtimer_usleep riotboot/flash-slot1 term

Issues/PRs references

Related to #11641

@fjmolinas fjmolinas added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: OTA Area: Over-the-air updates labels Jun 6, 2019
@fjmolinas fjmolinas requested a review from aabadie June 6, 2019 09:57
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 6, 2019
@aabadie
Copy link
Contributor

aabadie commented Jun 6, 2019

Awesome!

@fjmolinas fjmolinas mentioned this pull request Jun 6, 2019
Merged
aabadie
aabadie approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. Thanks for providing in a comment the reason why RIOTBOOT_HDR_LEN requires alignment.

Test on nucleo-l476rg works. I also tested tests/periph_flashpage since CPU_FLASH_BASE was added (and was initially missing).

ACK and go

@aabadie aabadie merged commit 18bb31c into RIOT-OS:master Jun 14, 2019
@aabadie aabadie mentioned this pull request Jun 14, 2019
Merged
@fjmolinas fjmolinas deleted the pr_stm32l4_riotboot branch August 7, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: OTA Area: Over-the-air updates CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @aabadie