-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/driver_sht2x: avoid negative number after decimal dot #12164
Conversation
Also don't include printf_float
Notice that sht3x has a similar problem too. But that one has a bug as well, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same logic as in the other two PRs applies.
In the sht3x test there is this:
Not only does it need an abs() for the numbers after decimal dot, it has |
I mean the format string is device independent, no?
so we can set |
There's indeed a problem, the formatter for temperature should be |
well, in fact it's not needed since the number after decimal dot is divided by 10. But this division could be removed if you use |
This is a similar fix as in #12162 and #12140.