Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mrf24j40: add pseudomodules for MRF24J40MA/B/C/D/E #12327

Merged
merged 1 commit into from
Sep 29, 2019
Merged

drivers/mrf24j40: add pseudomodules for MRF24J40MA/B/C/D/E #12327

merged 1 commit into from
Sep 29, 2019

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Sep 28, 2019 •
edited
Loading

Contribution description

Microchip offers ready-to-use modules with the mrf24j40 chip.
All but the MRF24J40MA integrate an external PA/LNA, they also come with an RF shield.

If the PA/LNA is not enabled, the signal off these modules is really poor.

This adds pseudomodules so that the PA/LNA is automatically enabled when the appropriate module is used.

Linux does something simmilar.

Testing procedure

Tested using a MRF24J40MD

withUSEMODULE += mrf24j40
2019-09-28 19:27:11,931 # 12 bytes from fe80::2123:2323:2323:2322: icmp_seq=0 ttl=64 rssi=-78 dBm time=9.878 ms
2019-09-28 19:27:12,930 # 12 bytes from fe80::2123:2323:2323:2322: icmp_seq=1 ttl=64 rssi=-78 dBm time=7.644 ms
2019-09-28 19:27:13,932 # 12 bytes from fe80::2123:2323:2323:2322: icmp_seq=2 ttl=64 rssi=-78 dBm time=8.301 ms
withUSEMODULE += mrf24j40md
2019-09-28 19:27:41,852 # 12 bytes from fe80::2123:2323:2323:2322: icmp_seq=0 ttl=64 rssi=-20 dBm time=10.416 ms
2019-09-28 19:27:42,852 # 12 bytes from fe80::2123:2323:2323:2322: icmp_seq=1 ttl=64 rssi=-19 dBm time=9.888 ms
2019-09-28 19:27:43,855 # 12 bytes from fe80::2123:2323:2323:2322: icmp_seq=2 ttl=64 rssi=-20 dBm time=10.845 ms

Issues/PRs references

follow-up to #11410

@benpicco
drivers/mrf24j40: add pseudomodules for MRF24J40MA/C/D/E
0bb04cf 
Microchip offers ready-to-use modules with the mrf24j40 chip.
All but the MRF24J40MA integrate an external PA/LNA, they also come
with an RF shield.

If the PA/LNA is not enabled, the signal off these modules is really
poor.

This adds pseudomodules so that the PA/LNA is automatically enabled
when the appropriate module is used.
@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 28, 2019
@benpicco benpicco changed the title drivers/mrf24j40: add pseudomodules for MRF24J40MA/C/D/E drivers/mrf24j40: add pseudomodules for MRF24J40MA/B/C/D/E Sep 28, 2019
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Sep 29, 2019
@maribu maribu added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Sep 29, 2019
maribu
maribu approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This PR is small and contains nothing scary, especially as no C files/headers are touched. So, untested ACK

@maribu maribu merged commit 6cbb7ad into RIOT-OS:master Sep 29, 2019
@benpicco benpicco deleted the mrf24j40-pseudomodules branch September 29, 2019 19:36
@kb2ma kb2ma added this to the Release 2019.10 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @maribu @kb2ma