tests/gnrc_rpl_srh: fix test assumption [backport 2019.10] #12443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12440
Contribution description
If the destination address or an address within the source route is multicast within a RPL source routing header, a receiving node is supposed to just discard the packets, but not to send an ICMPv6 error message, as the test assumes at the moment.
Source: https://tools.ietf.org/html/rfc6554#section-4.2
There is also a fix that prevents the implementation from sending such an error message: If we leave the
err_ptr
unset in these cases, the node will not send an error message.Testing procedure
Read the algorithm provided above, especially the section regarding multicast:
The test cases that check multicast addresses in
tests/gnrc_rpl_srh
should now pass (the test in general does not pass completely (but will, when #12442 is cherry-picked).Issues/PRs references
Fixes one of the issues in #12436
Accompanies #12442