Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/cc26xx_cc13xx: fix typo on XOSC selection #15215

Merged
merged 2 commits into from
Oct 12, 2020
Merged

cpu/cc26xx_cc13xx: fix typo on XOSC selection #15215

merged 2 commits into from
Oct 12, 2020

Conversation

jeandudey
Copy link
Contributor

Contribution description

  • Fixes a typo on XOSC selection bitfield that would
    make the CPU crash when changing it.
  • Sets the other fields to their default values.
  • Fixes another bug when changing the oscillator.

Testing procedure

  • make -C examples/hello-world menuconfig all flash BOARD=cc1312-launchpad to open menu config, select update CCFG and flash the firmware.

Issues/PRs references

@jeandudey
cpu/cc26xx_cc13xx: fix typo on XOSC selection
becca71 
> Fixes a typo on XOSC selection bitfield that would
make the CPU crash when changing it.
> Sets the other fields to their default values.

Signed-off-by: Jean Pierre Dudey <me@jeandudey.tech>
@jeandudey
cpu/cc26x2_cc13x2: fix boolean logic for osc change
ca12659 
Small typo on the loop that checks that the oscillator is ready to be
changed.

Signed-off-by: Jean Pierre Dudey <me@jeandudey.tech>
@jeandudey jeandudey requested a review from smlng as a code owner October 12, 2020 19:45
@benpicco benpicco added Area: cpu Area: CPU/MCU ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 12, 2020
benpicco
benpicco approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and makes sense.
Does this need a backport to the stable release branch?

@jeandudey
Copy link
Contributor Author

Does this need a backport to the stable release branch?

CCFG was added recently and the oscillator bug can't be hit on the stable branch unless application code is using it directly, it will get used only by the radio, so I don't think it should be backported.

@benpicco benpicco merged commit 2df92b0 into RIOT-OS:master Oct 12, 2020
@jeandudey jeandudey deleted the 2020_10_12-ccfg-xosc branch October 12, 2020 21:01
@jeandudey
Copy link
Contributor Author

Thanks for the review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeandudey @benpicco