-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: add support for DS3231 RTC #15245
Conversation
a645560
to
5ca66ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Code looks good, and given that the DS3234 driver only implements only one function it makes sense to implement a new driver (with the potential of merging them later also with other variants). Tested with samr21-xpro
, all functions work as expected.
Tested with the feather-m0 board and https://www.adafruit.com/product/3028
|
Ah yeah, apart from the test command I also tested the other commands provided in the test, to increase the coverage of my tests. :-) |
5ca66ca
to
2946716
Compare
pushed some minor static fixes, as pointed out by murdock, and squashed. |
ACK upholds. |
There are still some boards for which the test is to small: |
2946716
to
24c3f56
Compare
updated blacklisted boards, hopefully i caught them all... |
Then let's go! :-) |
Contribution description
For a current project I was in the need for a battery-backed real-time clock and so I ended up with some
ds3231
modules. This PR adds basic support for these devices to RIOT. Unfortunately my modules to not provide access to the 32khz nor the interrupt/square wave pins, so I was not able to test that functionality. In the end I decided to also omit the alarm and square wave code from this PR altogether. If somebody is interested that code can be found here: https://github.com/haukepetersen/RIOT/tree/add_driver_ds3231_alarm_sqwNote: there is some slight overlap with the existing
ds3234
driver, that would be worth of being merged together at some point. For now I decided to keep this PR independent as I want to get a little better overview on the other devices of theds323x
family before merging the code bases...Testing procedure
Connect a ds3231 device to a board of your choice and run the
test
shell command from the provided test application.Issues/PRs references
none