boards/nucleo*: move HSE/LSE configuration for Kconfig to common #15634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: cleanup
aabadie
requested review from
cgundogan,
DipSwitch,
fjmolinas,
jia200x and
vincent-d
as code owners
aabadie
force-pushed
the
pr/boards/nucleo-common-kconfig-hse
branch
from
4a4a519
to
1f92845
Compare
aabadie
removed
the
State: waiting for other PR
aabadie
force-pushed
the
pr/boards/nucleo-common-kconfig-hse
branch
from
1f92845
to
de37259
Compare
aabadie
added
the
CI: ready for build
|
no longer waiting for another PR. |
fjmolinas
reviewed
Jan 21, 2021
fjmolinas
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
ACK, changes look good all timing related tests are still passing https://ci.inria.fr/ci-riot-tribe/job/build-pipeline.jk/214/artifact/ (the failing rtc test was fixed in another unrelated PR)
fjmolinas
added
CI: ready for build
|
The build failed on Murdock because of Kconfig: there was a wrong selection of the common kconfig symbol (nucleo64 instead of nucleo144). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Most of the nucleo boards share the same HSE/LSE hardware configuration:
Instead of describing this for each nucleo boards, move the selection of
BOARD_HAS_HSE/BOARD_HAS_LSEconfig to boards/common/nucleo32/64/144 Kconfig files.Testing procedure
Nucleo boards are still functional when Kconfig is used and the configuration is as expected.
Issues/PRs references
#14975
based on #15632