Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static_tests: enable shellcheck and annote its output #15756

Merged
merged 3 commits into from
Jan 14, 2021
Merged

static_tests: enable shellcheck and annote its output #15756

merged 3 commits into from
Jan 14, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 12, 2021 •
edited
Loading

Contribution description

This enables the the shellcheck check in the static tests (without it erroring) and enables annotations for it.

Testing procedure

I provided a test commit (which reverts the fixes of shellcheck I fixed here) that will cause some annotations.

Issues/PRs references

None

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: CI Area: Continuous Integration of RIOT components Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 12, 2021
@miri64 miri64 force-pushed the dist/enh/shellcheck-enabled branch 14 times, most recently from 65a15dd to dd8aaf1 Compare January 12, 2021 22:09
@miri64 miri64 added Area: tools Area: Supplementary tools and removed Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … labels Jan 13, 2021
@miri64 miri64 force-pushed the dist/enh/shellcheck-enabled branch from dd8aaf1 to 978232e Compare January 13, 2021 14:35
@miri64
Copy link
Member Author

miri64 commented Jan 13, 2021

Rebased to current master to resolve conflict.

@miri64
Copy link
Member Author

miri64 commented Jan 13, 2021

Since shellcheck is now part of riotdocker, so I removed the adaptation to install it.

@miri64
Copy link
Member Author

miri64 commented Jan 13, 2021

Restarted the static jobs because the new image is only up for 40 min.

@miri64
Copy link
Member Author

miri64 commented Jan 13, 2021

Now the static tests run :-)

@jia200x
Copy link
Member

jia200x commented Jan 13, 2021

awesome! :)

jia200x
jia200x approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. The annotations are there and having shellcheck in RIOT docker is even better :).

Please squash and remove bogus commit

@miri64 miri64 force-pushed the dist/enh/shellcheck-enabled branch from cf29cc4 to 89418e4 Compare January 13, 2021 21:04
@miri64
Copy link
Member Author

miri64 commented Jan 13, 2021

Done

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 14, 2021
@miri64 miri64 merged commit 09463b7 into RIOT-OS:master Jan 14, 2021
@miri64 miri64 deleted the dist/enh/shellcheck-enabled branch January 14, 2021 00:21
@miri64
Copy link
Member Author

miri64 commented Jan 14, 2021

Thanks for the review, @aabadie and @jia200x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @jia200x @aabadie