Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/tools/headerguards: fix comment for current code #15768

Merged
merged 1 commit into from
Jan 14, 2021
Merged

dist/tools/headerguards: fix comment for current code #15768

merged 1 commit into from
Jan 14, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 14, 2021

Contribution description

While searching for other occurrences of the bug I found in #15767, I found a comment in the static tests that was outdated and referred to a previous state of #15746.

Testing procedure

Read and make sure the comment is now correct.

Issues/PRs references

Follow-up on #15746.

@miri64 miri64 added Area: doc Area: Documentation Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 14, 2021
@miri64 miri64 added this to the Release 2021.01 milestone Jan 14, 2021
@miri64 miri64 requested a review from jia200x January 14, 2021 11:29
jia200x
jia200x approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. ACK

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 14, 2021
@miri64 miri64 merged commit 6dfdde9 into RIOT-OS:master Jan 14, 2021
@miri64 miri64 deleted the dist/fix/headerguards-comment branch January 14, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components Area: doc Area: Documentation Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2021.01
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @jia200x