New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: model newlib as a FEATURE #15859
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
Area: build system
Area: Build system
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
labels
Jan 26, 2021
fjmolinas
requested review from
bergzand,
cgundogan,
gschorcht,
jia200x,
kaspar030,
leandrolanzieri and
maribu
as code owners
January 26, 2021 16:29
@aabadie if you don't find a typo or other such change, mind triggering the ci? |
aabadie
reviewed
Jan 26, 2021
fjmolinas
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Jan 27, 2021
fjmolinas
force-pushed
the
pr_newlib_feature
branch
from
January 27, 2021 08:01
b695a94
to
e4d6109
Compare
fjmolinas
removed
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Jan 27, 2021
fjmolinas
force-pushed
the
pr_newlib_feature
branch
from
January 27, 2021 08:27
e4d6109
to
63a2a6c
Compare
fjmolinas
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Jan 27, 2021
Forgot to add the symbol |
All green @aabadie! |
aabadie
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and required cleanup ! Thanks @fjmolinas.
I trust your testing and Murdock is all green.
ACK!
Thanks for the review! |
15 tasks
fjmolinas
added a commit
to fjmolinas/RIOT
that referenced
this pull request
Feb 16, 2021
RIOT-OS#15859 exposed a bug in the handling of FEATURES_REQUIRED_ANY, so RIOT-OS#15935 did not run this test, native is currently failing, so blacklist while this is still the case
fjmolinas
added a commit
to fjmolinas/RIOT
that referenced
this pull request
Feb 16, 2021
RIOT-OS#15859 exposed a bug in the handling of FEATURES_REQUIRED_ANY, so RIOT-OS#15935 did not run this test, native is currently failing, so blacklist while this is still the case
fjmolinas
added a commit
to fjmolinas/RIOT
that referenced
this pull request
Feb 16, 2021
RIOT-OS#15859 exposed a bug in the handling of FEATURES_REQUIRED_ANY, so RIOT-OS#15935 did not run this test, native is currently failing, so blacklist while this is still the case
fjmolinas
added a commit
to fjmolinas/RIOT
that referenced
this pull request
Feb 16, 2021
RIOT-OS#15859 exposed a bug in the handling of FEATURES_REQUIRED_ANY, so RIOT-OS#15935 did not run this test, native is currently failing, so blacklist while this is still the case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: build system
Area: Build system
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR models
newlib
as a feature and makes use ofFEATURES_REQUIRED_ANY
to allow requesting any of bothpicolibc
andnewlibc
while only having one selected.This way applications can enforce one of them with
FEATURES_REQUIRED += %
. IMO only applications should enforce this, otherwise, a conflict is likely to arise,FEATURES_CONFLICT
is added to prevent this.Testing procedure
Verify that dependencies are still correct. Some here
Issues/PRs references
Split from #15832