makefiles/info-global.inc.mk: reset features_required_any #16026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
the
CI: ready for build
fjmolinas
commented
Feb 16, 2021
fjmolinas
force-pushed
the
pr_fix_native
branch
from
1109178
to
8d63bc1
Compare
fjmolinas
changed the title
fjmolinas
added
Area: build system
fjmolinas
requested review from
aabadie,
cgundogan,
haukepetersen,
leandrolanzieri,
MichelRottleuthner,
miri64,
PeterKietzmann and
smlng
as code owners
|
I think I dealt with the issues and introduced a temporary blacklist for native on the failing flashpage related tests. |
RIOT-OS#15859 exposed a bug in the handling of FEATURES_REQUIRED_ANY, so RIOT-OS#15935 did not run this test, native is currently failing, so blacklist while this is still the case
fjmolinas
force-pushed
the
pr_fix_native
branch
from
34205af
to
97b15a6
Compare
benpicco
reviewed
Feb 16, 2021
benpicco
reviewed
Feb 16, 2021
| # handling of FEATURES_REQUIRED_ANY, so https://github.com/RIOT-OS/RIOT/pull/15935 | ||
| # did not run unittests, native is currently failing, so blacklist while this | ||
| # is still the case | ||
| FEATURES_BLACKLIST += arch_native |
There was a problem hiding this comment.
Well the thing is the test is not run without this PR, do you mind removing in your PR?
The test uses module functions, so require it.
fjmolinas
force-pushed
the
pr_fix_native
branch
from
97b15a6
to
1d8448d
Compare
miri64
reviewed
Feb 16, 2021
miri64
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
#15859 added the
newlibfeature, which is added as a dependency for someBOARDs asFEATURES_REQUIRED_ANY, this was not cleaned, this made the requirement persist and contaminate the en result. This PR fixes it, but probably some broken tests will show up.Tracking previously uncaught issues:
Testing procedure
This once a RED Murdock should show it.