Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/lorawan: Revert #16604 and fix NETOPT_RX_SYMBOL_TIMEOUT documentation [backport 2021.07] #16648

Merged
merged 5 commits into from
Jul 14, 2021
Merged

net/lorawan: Revert #16604 and fix NETOPT_RX_SYMBOL_TIMEOUT documentation [backport 2021.07] #16648

merged 5 commits into from
Jul 14, 2021

Conversation

jia200x
Copy link
Member

@jia200x jia200x commented Jul 14, 2021 •
edited by leandrolanzieri
Loading

Contribution description

Backport of #16640 .

This backport is not a copy of #16640:

Testing procedure

Same as #16640 .

Issues/PRs references

#16640 .

@jia200x jia200x added the Process: release backport Integration Process: The PR is a release backport of a change previously provided to master label Jul 14, 2021
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Jul 14, 2021
@jia200x jia200x added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) and removed Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Jul 14, 2021
@MrKevinWeiss MrKevinWeiss added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Jul 14, 2021
@MrKevinWeiss
Copy link
Contributor

Lets wait for #16647 then rebase then run the tests (I want to do hardware tests as well since I can then check it off for the upcoming RC)

@MrKevinWeiss
Copy link
Contributor

Ready for rebase, please set the murdock hil tests and CI build test label when you are done.

@MrKevinWeiss
Copy link
Contributor

ping @jia200x

@jia200x jia200x force-pushed the backport/2021.07/pr/revert/rx_symbol branch from 6dd739a to 38c9873 Compare July 14, 2021 17:51
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Jul 14, 2021
@jia200x
Copy link
Member Author

jia200x commented Jul 14, 2021

done!

@MrKevinWeiss MrKevinWeiss added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 14, 2021
@jia200x
Copy link
Member Author

jia200x commented Jul 14, 2021

all green

MrKevinWeiss
MrKevinWeiss approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x jia200x merged commit 1a4b35a into RIOT-OS:2021.07-branch Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan cgundogan is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas fjmolinas is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen haukepetersen is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: LoRa Area: LoRa radio support Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jia200x @MrKevinWeiss