Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng_netconf: adapt byte orders to output #2885

Closed
wants to merge 3 commits into from

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 29, 2015

The byte order of addresses in ng_netdev/ng_netconf is a little bit messed up:

  • The shell output and configuration it's unclear: For Ethernet it's network byte order, though the doc states it's in host byte order, for ng_at86rf2xx it is little endian (regardless of the host byte order), because
  • for sending ng_at86rf2xx assumes the address is stored in little endian
  • I don't even know know what xbee is doing.

My solution: addresses (including PAN ID) shall always be configured in network byte (big endian) order. If the protocol does not use network byte order (e.g. IEEE 802.15.4) it needs to convert it to their specific order.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: doc Area: Documentation Area: drivers Area: Device drivers NSTF labels Apr 29, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Apr 29, 2015
@miri64 miri64 added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label Apr 29, 2015
@miri64 miri64 added the State: archived State: The PR has been archived for possible future re-adaptation label Jul 1, 2015
@miri64
Copy link
Member Author

miri64 commented Jul 1, 2015

Need to rethink this one.

@miri64 miri64 closed this Jul 1, 2015
@miri64 miri64 deleted the netconf/fix/byteorder branch July 1, 2015 11:07
@miri64 miri64 added the Area: network Area: Networking label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: drivers Area: Device drivers Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: archived State: The PR has been archived for possible future re-adaptation Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants