boards: Add support for Nucleo-f401 #4119
Conversation
PeterKietzmann
added
Platform: ARM
|
@katezilla Ok, I just noticed that there was already PR on this exactly same board. #2601 Which one should we try to merge? |
|
oh, well you just missed it, but i forgot it completly. |
| */ | ||
| #define LED_GREEN_PORT (GPIOA) | ||
| #define LED_GREEN_PIN (5) | ||
| /** @} */ |
There was a problem hiding this comment.
also please add here LED_GPIO GPIO(PORT_A,5)
|
ping @katezilla |
| FEATURES_PROVIDED += periph_uart | ||
| FEATURES_PROVIDED += periph_gpio | ||
| FEATURES_PROVIDED += periph_spi | ||
| FEATURES_PROVIDED += periph_cpuid |
There was a problem hiding this comment.
Please remove periph_spi and periph_cpuid as these are not provided by your port.
My bad, I confused it, please ignore my comment.
thomaseichinger
added
the
CI: ready for build
|
Travis fails qemu-i386 tests, everything else runs smoothly. And I don't understand what happens with Strider. :) |
|
@latsku I kicked Travis. Strider builds are only included experimentally but decisions are based on Travis' outcome. |
|
@thomaseichinger just to be sure, did you test it? I were not able to test it yet |
|
@katezilla No I didn't, I don't have access to the hardware and won't for the next couple days either. |
|
ping @katezilla @thomaseichinger No pressure, just keeping this active. |
|
@thomaseichinger, @katezilla, ping. |
|
Seems like, i don't have the Hardware either... |
|
@katezilla you wanted to review the code without testing, because of our lack of hardware. Are you done with that, would you ACK? Then Thomas can check if it properly runs on hardware |
|
@PeterKietzmann @katezilla Checking the hardware stock, I don't have access to this board. If nobody else does, this will be eyes only review. |
|
@PeterKietzmann yes im done reviewing. |
|
Was that an ACK then? |
|
Yes, ACK from me. |
| #define SPI_0_DEV SPI1 | ||
| #define SPI_0_CLKEN() (RCC->APB2ENR |= RCC_APB2ENR_SPI1EN) | ||
| #define SPI_0_CLKDIS() (RCC->APB2ENR &= ~RCC_APB2ENR_SPI1EN) | ||
| #define SPI_0_BUS_DIV 1 /* 1 -> SPI runs with half CPU clock, 0 -> quarter CPU clock */ |
There was a problem hiding this comment.
@latsku Could you please change SPI to SPI bus in the comment?
|
@latsku Two more minor comments. |
|
Fixed the comment and led initialization to turn off the leds on start. Previously turned on the led for debugging. |
|
@latsku please squash your commits to one commit that states the initial import of the boards (e.g. something like "board/nucleoXYZ: initial import" ). I will immediately merge after Travis agreed on it then |
cpu: Add support for STM32F401xE cpu boards: Add support for Nucleo-f401 boards/nucleo-f401: New line fixes and comment on green led pin board/nucleo-f401: Added LED GPIO board/nucleo-f401: Fixed LED GPIO board/nucleo-f401: Minor fixes
|
and go |
boards: Add support for Nucleo-f401
Hi,
This PR contains definitions for the nucleo-f401 board and the MCU (ST32F401). With 512kb flash and 96kb RAM this is nice development board for networking.
At the moment implemented peripherals are: