fix warnings/errors thrown by clang on OS X #4444
Conversation
OlegHahm
added
Type: bug
|
Should we consider this as a bug that should be fixed for 2015.12? I would tend to yes. |
|
@Yonezawa-T2 Thanks a lot for these fixes. |
thomaseichinger
added
the
CI: ready for build
| @@ -87,7 +87,7 @@ static gnrc_pktsnip_t *_recv(gnrc_netdev2_t *gnrc_netdev2) | |||
| DEBUG("gnrc_netdev2_eth: received packet from %02x:%02x:%02x:%02x:%02x:%02x " | |||
| "of length %zu\n", | |||
| hdr->src[0], hdr->src[1], hdr->src[2], hdr->src[3], hdr->src[4], | |||
| hdr->src[5], nread); | |||
| hdr->src[5], (size_t) nread); | |||
There was a problem hiding this comment.
For this it might makes sense to actually change the printf formatting option.
There was a problem hiding this comment.
Did you push? For me it is still (size_t) nread.
There was a problem hiding this comment.
I forgot to git add, only changed commit message. Now updated.
|
@OlegHahm I'd agree, this should go into 2015.12. |
|
@Yonezawa-T2 Could you please prefix your commit message with "OSX: ...". |
Yonezawa-T2
force-pushed
the
fix_clang_warnings_for_os_x
branch
from
edc7a5b
to
092dfe3
Compare
|
This PR is only for a portion of XBee and GNRC. We should enable debug for all modules and compile those modules in the future. |
|
ACK when #4444 (comment) is addressed and Travis passed again. |
gnrc_ipv6_nc, gnrc_sixlowpan, gnrc_netdev2_eth, gnrc_ipv6, xbee, sixlowpan, sc_gnrc_6ctx
Yonezawa-T2
force-pushed
the
fix_clang_warnings_for_os_x
branch
from
092dfe3
to
c36766a
Compare
|
@thomaseichinger Changed format string to |
|
@Yonezawa-T2 Great, thank you. ACK & Go |
fix warnings/errors thrown by clang on OS X
Clang on OS X complains about mixture of signed/unsigned integers. This PR reliefs some errors around XBee and GNRC.