xbee: fixed several bugs #4445

Yonezawa-T2 · 2015-12-09T10:04:09Z

This PR fixes several bugs in XBee driver.

tx_lock is not unlocked
destination address field for broadcast packet is wrong
RSSI header field is incorrectly parsed
adds debug output of incoming/outgoing packets
short address should be disabled when long address is enabled
channel 0x1A is not supported by XBee-PRO
_set_addr destructs long address in memory
adds packet filtering functionality for debugging to emulate non-transitive network

See commit messages for details.

Tested on OS X with modifications of #4443 and #4444.

Yonezawa-T2 · 2015-12-09T10:33:54Z

XBee 802.15.4 manual is at http://ftp1.digi.com/support/documentation/90000982_S.pdf

See "Figure 23: TX Packet (16-bit address) frames" (p.95) for API format for destination address field for broadcast packet e99759f.

See "Figure 25: RX packet (64-bit address) frames" and "Figure 26: RX Packet (16-bit address) frames" (p.96) for RSSI header field 5f56ef2.

See Unicast Mode section (p.28) for behavior of short address and long address 5807145.

See "Table 11: XBee / XBee-PRO commands" (p.41) for valid channels of XBee and XBee-PRO 7c36311.

haukepetersen · 2015-12-09T11:10:39Z

Awesome catches! Testing it now.

haukepetersen · 2015-12-09T12:26:58Z

first quick test results:

the code changes look sane (especially the byte offsets for the TX and RX frames - I who's idea it was to skip byte 4...)
Sending works gread (with short and long addresses)
Receiving does not seem to work for me, but I am not sure if it is the driver of my setup... Looking into this

Yonezawa-T2 · 2015-12-10T02:58:53Z

I tested using branch https://github.com/Yonezawa-T2/RIOT/tree/xbee_border_router, which contains other fixes on GNRC, particularly #4446 affects sender's IPv6 address and ICMPv6 check sum.

OlegHahm · 2016-02-27T18:50:05Z

@Yonezawa-T2, can you rebase, please?
@haukepetersen, would you ACK?

Yonezawa-T2 · 2016-02-29T04:06:15Z

rebased.

Yonezawa-T2 · 2016-03-14T05:05:54Z

Should I split the PR into separate PRs? Some of the commits are bug fixes while others are enhancements.

Yonezawa-T2 · 2016-03-14T07:03:13Z

Reordered commits so that we can drop enhancement commits by git-reset.

haukepetersen · 2016-04-01T11:25:42Z

drivers/xbee/xbee.c

@@ -289,9 +307,19 @@ static int _set_addr_len(xbee_t *dev, uint16_t *val, size_t len)
    switch (*val) {
        case 8:
            dev->addr_flags |= XBEE_ADDR_FLAGS_LONG;
+
+            // disable short address


please use c-style comments...

Yonezawa-T2 · 2016-04-04T01:22:38Z

Rebased.

kYc0o · 2016-04-16T22:25:58Z

ping @Yonezawa-T2 can you rebase again? sorry for the delay, I'll test this ASAP.

Destination address is at tx_buf[5] and tx_buf[6] rather than tx_buf[4] and tx_buf[5]. Broadcast header is overridden by following code mistakenly.

Yonezawa-T2 · 2016-04-18T01:24:42Z

Rebased.

kYc0o · 2016-04-18T14:04:23Z

@kaspar030 can you look at the error? I cannot get why it's failing...

OlegHahm · 2016-04-18T14:12:41Z

It's failing because two commits need squashing (according to their commit messages).

kYc0o · 2016-04-18T14:44:54Z

Oh... can we have a bit more output on that?

kYc0o · 2016-04-18T14:46:11Z

@Yonezawa-T2 so, can you squash? I think this is ready :) I'll do some more tests in the mean time

OlegHahm · 2016-04-18T14:46:30Z

It's saying:

Pull request needs squashing:
37def13 SQUASH ME xbee: fixed comment style for "fixed RSSI header parsing"
4358c17 SQUASH ME xbee: fixed comment style for "disable short address..."

kYc0o · 2016-04-18T15:09:42Z

Oh yeah, but since there is no "error" or something like that, in the whole black output I wasn't unable to see it. Thanks!

kYc0o · 2016-04-18T21:54:59Z

Works like a charm. Waiting for squashing and Murdock afterwards.

XBee supports channels 0x0B-0x1A while XBee-PRO supports only 0x0C-0x17.

XBee sends short address even for `API_ID_TX_LONG_ADDR` if short address is enabled. This results in check sum error of ICMPv6 since the IP address is computed based on long address on the sender side while it is computed based on short address on the receiver side.

`_set_addr` is called from `xbee_init` with lower bytes of the long address. If `_set_addr` destructs the given address, the long address is also destructed.

When debugging multihop wireless network, it is useful to emulate non-transitive network, that is, node A can communicate with B and B can communicate with C, but A cannot communicate with C directly. If `XBEE_DENIED_ADDRESSES`, which is an array of XBee long addresses, is defined, packets from those addresses are dropped silently. Example: CFLAGS += "-DXBEE_DENIED_ADDRESSES={ 0x02, 0x12, 0x34, 0x56, 0x78, 0x9a, 0xbc, 0xde, 0x02, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11 }"

Yonezawa-T2 · 2016-04-19T02:18:54Z

[del]Rebased.[/del]
[edit]Squashed.[/edit]

kYc0o · 2016-04-19T07:52:35Z

ACK and GO!

miri64 · 2016-04-19T10:31:23Z

Needs backport

miri64 · 2016-04-19T10:44:11Z

Nope, already in releas branch. Sorry.

miri64 · 2016-04-19T10:45:56Z

Arghs... this is so confusing.... no it is not in release branch... please provide a backport...

kYc0o · 2016-04-19T11:51:11Z

Yes it needs it :)

Yonezawa-T2 mentioned this pull request Dec 9, 2015

gnrc_ndp: fixed ND Option handling for 6LoWPAN #4446

Merged

OlegHahm assigned haukepetersen Dec 9, 2015

OlegHahm added this to the Release 2016.03 milestone Dec 9, 2015

OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: drivers Area: Device drivers labels Dec 9, 2015

This was referenced Dec 9, 2015

fixes several bugs on GNRC network stack #4447

Merged

examples: add example of border router with XBee on native platform. #4448

Closed

This was referenced Feb 4, 2016

xbee: add timeout for AT command response (fixes #4731) #4734

Merged

driver xbee and uart #4731

Closed

OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 27, 2016

Yonezawa-T2 force-pushed the fix_xbee branch from d5aed5a to 61e2424 Compare February 29, 2016 04:06

Yonezawa-T2 force-pushed the fix_xbee branch from 61e2424 to 468f30b Compare March 14, 2016 06:56

Yonezawa-T2 mentioned this pull request Apr 1, 2016

drivers/xbee: fixed missing newline in DEBUG #5226

Merged

haukepetersen reviewed Apr 1, 2016
View reviewed changes

kYc0o removed the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Apr 1, 2016

Yonezawa-T2 force-pushed the fix_xbee branch from 468f30b to 5ee95b3 Compare April 4, 2016 01:10

Yonezawa-T2 added 2 commits April 18, 2016 10:20

xbee: fixed missing unlocks

4f864b0

xbee: fixed broadcast header

bea5eac

Destination address is at tx_buf[5] and tx_buf[6] rather than tx_buf[4] and tx_buf[5]. Broadcast header is overridden by following code mistakenly.

Yonezawa-T2 force-pushed the fix_xbee branch from 5ee95b3 to 37def13 Compare April 18, 2016 01:24

kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 18, 2016

Yonezawa-T2 added 6 commits April 19, 2016 11:17

xbee: fixed RSSI header parsing

8481d85

xbee: changed default channel from 0x1A to 0x17 to support XBee-PRO

67c3ab8

XBee supports channels 0x0B-0x1A while XBee-PRO supports only 0x0C-0x17.

xbee: fixed that _set_addr destructed given address.

a6ae7c8

`_set_addr` is called from `xbee_init` with lower bytes of the long address. If `_set_addr` destructs the given address, the long address is also destructed.

xbee: enriched debug output

eb7cc30

Yonezawa-T2 force-pushed the fix_xbee branch from 37def13 to eb7cc30 Compare April 19, 2016 02:18

kYc0o merged commit f968ea0 into RIOT-OS:master Apr 19, 2016

miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016

miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016

miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016

miri64 mentioned this pull request Apr 19, 2016

xbee: fixed several bugs (backport) #5345

Merged

miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xbee: fixed several bugs #4445

xbee: fixed several bugs #4445

Yonezawa-T2 commented Dec 9, 2015

Yonezawa-T2 commented Dec 9, 2015

haukepetersen commented Dec 9, 2015

haukepetersen commented Dec 9, 2015

Yonezawa-T2 commented Dec 10, 2015

OlegHahm commented Feb 27, 2016

Yonezawa-T2 commented Feb 29, 2016

Yonezawa-T2 commented Mar 14, 2016

Yonezawa-T2 commented Mar 14, 2016

haukepetersen Apr 1, 2016

Yonezawa-T2 Apr 4, 2016

Yonezawa-T2 commented Apr 4, 2016

kYc0o commented Apr 16, 2016

Yonezawa-T2 commented Apr 18, 2016

kYc0o commented Apr 18, 2016

OlegHahm commented Apr 18, 2016

kYc0o commented Apr 18, 2016

kYc0o commented Apr 18, 2016

OlegHahm commented Apr 18, 2016

kYc0o commented Apr 18, 2016

kYc0o commented Apr 18, 2016

Yonezawa-T2 commented Apr 19, 2016 •

edited

Loading

kYc0o commented Apr 19, 2016

miri64 commented Apr 19, 2016

miri64 commented Apr 19, 2016

miri64 commented Apr 19, 2016

kYc0o commented Apr 19, 2016

xbee: fixed several bugs #4445

xbee: fixed several bugs #4445

Conversation

Yonezawa-T2 commented Dec 9, 2015

Yonezawa-T2 commented Dec 9, 2015

haukepetersen commented Dec 9, 2015

haukepetersen commented Dec 9, 2015

Yonezawa-T2 commented Dec 10, 2015

OlegHahm commented Feb 27, 2016

Yonezawa-T2 commented Feb 29, 2016

Yonezawa-T2 commented Mar 14, 2016

Yonezawa-T2 commented Mar 14, 2016

haukepetersen Apr 1, 2016

Choose a reason for hiding this comment

Yonezawa-T2 Apr 4, 2016

Choose a reason for hiding this comment

Yonezawa-T2 commented Apr 4, 2016

kYc0o commented Apr 16, 2016

Yonezawa-T2 commented Apr 18, 2016

kYc0o commented Apr 18, 2016

OlegHahm commented Apr 18, 2016

kYc0o commented Apr 18, 2016

kYc0o commented Apr 18, 2016

OlegHahm commented Apr 18, 2016

kYc0o commented Apr 18, 2016

kYc0o commented Apr 18, 2016

Yonezawa-T2 commented Apr 19, 2016 • edited Loading

kYc0o commented Apr 19, 2016

miri64 commented Apr 19, 2016

miri64 commented Apr 19, 2016

miri64 commented Apr 19, 2016

kYc0o commented Apr 19, 2016

Yonezawa-T2 commented Apr 19, 2016 •

edited

Loading