Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_ndp_internal: add missing unlock when the pktbuf is full #4533

Merged
merged 1 commit into from
Jan 4, 2016
Merged

gnrc_ndp_internal: add missing unlock when the pktbuf is full #4533

merged 1 commit into from
Jan 4, 2016

Conversation

Yonezawa-T2
Copy link
Contributor

When pktbuf is full, gnrc_ndp_internal_send_rtr_adv returns without unlocking the mutex.
#4447 (comment)

Splitted from #4447.

@cgundogan
Copy link
Member

there are still some missing mutex_unlocks in this function (the following two return statements)

@cgundogan cgundogan added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Dec 22, 2015
@cgundogan cgundogan self-assigned this Dec 22, 2015
@cgundogan cgundogan added this to the Release 2015.12 milestone Dec 22, 2015
@OlegHahm OlegHahm added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Dec 22, 2015
@miri64
Copy link
Member

miri64 commented Dec 23, 2015

@cgundogan can you point them out please or provide a PR to @Yonezawa-T2's branch, to speed up the process a little ;-)

@cgundogan
Copy link
Member

see Yonezawa-T2#1

@cgundogan
Copy link
Member

thanks. Could you squash please?

@cgundogan cgundogan added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 24, 2015
@Yonezawa-T2
gnrc_ndp_internal: add missing unlock when the pktbuf is full
38d3dc7 
Squashed a commit by Cenk Gündoğan <cnkgndgn@gmail.com>.
@Yonezawa-T2
Copy link
Contributor Author

Squashed.

@OlegHahm OlegHahm added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Dec 25, 2015
@cgundogan
Copy link
Member

travis agrees - GO

cgundogan added a commit that referenced this pull request Jan 4, 2016
@cgundogan
Merge pull request #4533 from Yonezawa-T2/gnrc_add_missing_unlock
e79a471 
gnrc_ndp_internal: add missing unlock when the pktbuf is full
@cgundogan cgundogan merged commit e79a471 into RIOT-OS:master Jan 4, 2016
@cgundogan cgundogan mentioned this pull request Jan 4, 2016
Merged
@cgundogan cgundogan removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cgundogan cgundogan

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2015.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Yonezawa-T2 @cgundogan @miri64 @OlegHahm