gnrc_ndp_internal: add missing unlock when the pktbuf is full (Backport) #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
Type: bug
|
ACK and go, when travis is happy. |
| @@ -484,6 +485,7 @@ void gnrc_ndp_internal_send_rtr_adv(kernel_pid_t iface, ipv6_addr_t *src, ipv6_a | |||
| &ctx->prefix, pkt); | |||
| if (hdr == NULL) { | |||
| DEBUG("ndp rtr: error allocating 6CO\n"); | |||
| mutex_unlock(&ipv6_iface->mutex); | |||
| gnrc_pktbuf_release(pkt); | |||
There was a problem hiding this comment.
In the 1st diff'd line the order is gnrc_pktbuf_release then mutex_unlock.
In the latter two lines the order is reversed.
Is this intentional / correct?
There was a problem hiding this comment.
discussed this with @authmillenon. The order should be irrelevant in this case
There was a problem hiding this comment.
OK, just wanted to make sure. :)
cgundogan
force-pushed
the
pr/gnrc/add_missing_unlock
branch
2 times, most recently
from
403b2e8 to
348fa68
Compare
|
rebased to include the |
Squashed a commit by Cenk Gündoğan <cnkgndgn@gmail.com>.
cgundogan
force-pushed
the
pr/gnrc/add_missing_unlock
branch
from
348fa68 to
f25235d
Compare
|
Travis agrees - GO |
cgundogan
added a commit
that referenced
this pull request
Jan 5, 2016
gnrc_ndp_internal: add missing unlock when the pktbuf is full (Backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4533 (Thanks to @Yonezawa-T2)