Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: si70xx: fixed left shift compiler warning for 16bit platforms #5231

Merged
merged 2 commits into from
Apr 13, 2016
Merged

drivers: si70xx: fixed left shift compiler warning for 16bit platforms #5231

merged 2 commits into from
Apr 13, 2016

Conversation

malosek
Copy link
Contributor

@malosek malosek commented Apr 1, 2016

Hello,

minor compiler warning in si70xx driver for 16bits (msp430).

/home/malo/RIOT/drivers/si70xx/si70xx.c: In function ‘si70xx_get_serial’:
/home/malo/RIOT/drivers/si70xx/si70xx.c:152:5: error: left shift count >= width of type [-Werror]
/home/malo/RIOT/drivers/si70xx/si70xx.c:152:5: error: left shift count >= width of type [-Werror]
/home/malo/RIOT/drivers/si70xx/si70xx.c:154:5: error: left shift count >= width of type [-Werror]
/home/malo/RIOT/drivers/si70xx/si70xx.c:154:5: error: left shift count >= width of type [-Werror]
cc1: all warnings being treated as errors

wbr
malo

@jnohlgard
Copy link
Member

ACK

@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 2, 2016
@jnohlgard
Copy link
Member

(untested, I don't have the device)

@jnohlgard jnohlgard added this to the Release 2016.04 milestone Apr 2, 2016
@basilfx
Copy link
Member

basilfx commented Apr 3, 2016

I can test this tonight or tomorrow.

@basilfx
Copy link
Member

basilfx commented Apr 3, 2016

Tested it, and the driver still works, although I only have a 32-bit MCU to test it with.

@basilfx basilfx mentioned this pull request Apr 3, 2016
Merged
@malosek
Copy link
Contributor Author

malosek commented Apr 4, 2016

Hello Bas,
thanks for additional fixes, to be honest Im quite far to test the driver with real device. Since need to add i2c for msp430 first. btw is there already sw i2c implementation somewhere in RIOT (could not find any)?
wbr
malo

@malosek
drivers: si70xx: fixed si70xx_measure return value calculation on 16b…
b9705c8 
…it platforms

Signed-off-by: malo <malo@25cmsquare.io>
@malosek
Copy link
Contributor Author

malosek commented Apr 9, 2016

Hello,
added one more commit to make the driver to work on 16bits. got i2c working on msp430 and could pass the driver_si70xx test. would it be possible to merge #5240 as well?
wbr
malo

@malosek
Copy link
Contributor Author

malosek commented Apr 12, 2016

Hello,
all seems to be green, who will pull the trigger?
wbr
malo

@haukepetersen
Copy link
Contributor

Looking good, Murdock is happy -> and go.

@haukepetersen haukepetersen merged commit df574d6 into RIOT-OS:master Apr 13, 2016
@malosek malosek deleted the si70xx_driver_fix branch April 13, 2016 21:22
@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Needs backport.

@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Nope, already in release branch. Sorry.

@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Sorry some confusion in the logs.... This is not in the release branch so a backport is still needed...

@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
@miri64
Copy link
Member

miri64 commented Apr 19, 2016

Log is trolling me... It's already in the release branch (for sure this time, since a rebase of this PR to the release branch led to a noop)

@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2016.04
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@malosek @jnohlgard @basilfx @haukepetersen @miri64