drivers: si70xx: result bugfixes #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegHahm
added
Type: bug
| TEST_I2C_ADDR ?= 128 | ||
| TEST_PIN_EN ?= 57 | ||
| TEST_I2C_ADDR ?= 0x80 | ||
| TEST_PIN_EN ?= GPIO_PIN\(PD,9\) |
There was a problem hiding this comment.
I think it would make sense to choose something more generic here, as GPIO_PIN(0, 0), as PD is not defined for every cpu...
|
changes look good, ACK once the comment above is addressed. |
basilfx
force-pushed
the
feature/si70xx_improvements
branch
from
a0ca413
to
ed62d6c
Compare
|
Addressed the issue and rebased. |
haukepetersen
added
the
CI: ready for build
|
so let's see if Murdock it fine with this... |
|
Murdock is happy. Should I squash it into two commits (driver + test) or just one? |
|
@haukepetersen If #5231 get's merged first, I'll rebase onto that one once more. |
|
#5231 is merged, please rebase and let's merge this as soon as the CI is happy (again). |
basilfx
force-pushed
the
feature/si70xx_improvements
branch
from
ed62d6c
to
cf5e4c8
Compare
|
Murdock is happy. I already squashed it into one commit. |
|
|
miri64
added
Process: needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #5231, I found two bugs that I should have seen earlier.
si70xx_get_relative_humiditycould wrap around, resulting in humidity 100% where it should be ~0%. ffe3fe3 fixes this.si70xx_get_revisionandsi70xx_get_serialstart with tainted buffers. In case of I2C failures, I noticed that it still passedsi70xx_testbecause of exactly the right values in the buffers (possibly uncleared RAM). By clearing them on beforehand, they should return an invalid revision number or serial number. 08e7e3c fixes this.I also took the liberty of improving the test application.