pkg/openwsn: prevent build loop #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
added
Type: bug
|
I could also remove the target instead of just the command to execute, if desired. |
| @@ -5,6 +5,5 @@ PKG_VERSION=ff25e5d0ae5d344ed793a724d60532fb917bf1f8 | |||
| .PHONY: all | |||
|
|
|||
| all: git-download | |||
| "$(MAKE)" -C $(PKG_DIR) | |||
There was a problem hiding this comment.
Hm, but that line should actually build the package. It is wrong and should be $(MAKE)" -C $(PKG_BUILDDIR).
If you remove it, does the openwsn application build at all?
cgundogan
force-pushed
the
pr/pkg/openwsn
branch
from
179031f
to
1c73e7a
Compare
|
@kaspar030 you were right, it didn't build openwsn. I fixed it the way you proposed and amended the change. It now attempts to build openwsn (fails for other reasons, though) |
|
I included this bug fix into the current release, because it is .. a bug fix. However, the severity may be very low, because we currently have no working examples/applications utilizing openwsn. |
cgundogan
added
the
CI: ready for build
|
Anyone care to acknowledge? |
1 similar comment
|
Anyone care to acknowledge? |
|
ACK and go. |
cgundogan
added
the
Process: needs backport
cgundogan
removed
the
Process: needs backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build the
openwsnapplication from the application repository, then I get a build loop.A smiliar line is in
pkg/Makefile.git, so I guess it is not needed to repeat that inpkg/openwsn/Makefile