Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/cortex-m: Enable STKALIGN to make the Cortex-M keep the stack 8 byte aligned #5256

Merged

Conversation

DipSwitch
Copy link
Member

This was a part of my effort to fix 1891 but this was not the problem.

Anyhow a nice add. :)

 /* for Cortex-M3 r1p0 and up the STKALIGN option was added, but not automatically
  * enabled until revision r2p0. For 64bit function arguments to work properly this
  * needs to be enabled.
  */

…yte aligned on 4 byte aligned stack pointers
@DipSwitch DipSwitch added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Apr 6, 2016
@OlegHahm OlegHahm added this to the Release 2016.04 milestone Apr 6, 2016
@jnohlgard
Copy link
Member

ACK, don't have a cortex m3 r1p0 to test on though.

@DipSwitch
Copy link
Member Author

All stm32f1 others I don't know. :) tested and still worked.
On 7 Apr 2016 08:09, "Joakim Nohlgård" notifications@github.com wrote:

ACK, don't have a cortex m3 r1p0 to test on though.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#5256 (comment)

@DipSwitch DipSwitch added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 7, 2016
@haukepetersen
Copy link
Contributor

ACK also from my side, iotlab runs fine with this and Murdock is happy -> go

@haukepetersen haukepetersen merged commit acf9bf7 into RIOT-OS:master Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants