Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove ambigious _t postfixes in struct names #5262

Merged
merged 7 commits into from
Apr 11, 2016

Conversation

DipSwitch
Copy link
Member

Fixes: #1102

Ready for CI set to give Murdock some work. Local test seemd fine.

@DipSwitch DipSwitch added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 7, 2016
@DipSwitch DipSwitch added this to the Release 2016.04 milestone Apr 7, 2016
@@ -138,7 +138,7 @@ extern "C" {
* @sa cbor_clear
* @sa cbor_destroy
*/
typedef struct cbor_stream_t {
typedef struct cbor_stream {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is cbor_stream needed at all?

@DipSwitch DipSwitch force-pushed the pr/fix_struct_naming branch 2 times, most recently from cb2f308 to 5e9f683 Compare April 7, 2016 20:18
@DipSwitch
Copy link
Member Author

Addressed

@DipSwitch DipSwitch force-pushed the pr/fix_struct_naming branch 3 times, most recently from 022b00b to a8c24fc Compare April 8, 2016 06:13
@DipSwitch
Copy link
Member Author

Fixed pthread compile errors, fixed doxygen warnings (which Travis reported and Murdock not, although Travis thought the warnings to be ok)

@haukepetersen
Copy link
Contributor

Changes look valid to me, though Murdock is not really happy, yet. ACK once that is fixed.

@@ -93,12 +93,12 @@ typedef struct fib_sr_meta_t {
} fib_sr_meta_t;

/**
* @breif FIB table type for single hop entries
* @brief FIB table type for single hop entries
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch (:

@DipSwitch
Copy link
Member Author

Let's give Murdock another change =)

@DipSwitch
Copy link
Member Author

And it agree's.

@kaspar030
Copy link
Contributor

&go.

@kaspar030 kaspar030 merged commit 44db7bb into RIOT-OS:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants