Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_netdev2_ieee802154.c: increase buffer #5285

Merged
merged 1 commit into from
Apr 10, 2016

Conversation

kYc0o
Copy link
Contributor

@kYc0o kYc0o commented Apr 10, 2016

While debugging gnrc_netdev2_ieee802154, I found that the buffer for printing L2 addresses is too small.
This only increases the buffer for correct printing while debugging.

@kYc0o kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Apr 10, 2016
@kYc0o kYc0o added this to the Release 2016.04 milestone Apr 10, 2016
@cgundogan
Copy link
Member

Nice catch, looks good. I would however prefer a define for this length, something like #define GNRC_NETIF_HDR_L2ADDR_PRINT_LEN (GNRC_NETIF_HDR_L2ADDR_MAX_LEN * 3) in sys/include/net/gnrc/netif/hdr.h.

Then you can also replace the usage in sys/net/gnrc/netif/hdr/gnrc_netif_hdr_print.c:23

@cgundogan cgundogan changed the title sys/net/gnrc/link_layer/netdev2/gnrc_netdev2_ieee802154.c: increase buffer gnrc_netdev2_ieee802154.c: increase buffer Apr 10, 2016
@cgundogan
Copy link
Member

And can you also reword your commit message like I did with the PR title?

@kYc0o
Copy link
Contributor Author

kYc0o commented Apr 10, 2016

Ok fine, I can do that, but this constant is also used in gnrc_netif_hdr_print. Should I change both?

@cgundogan
Copy link
Member

Then you can also replace the usage in sys/net/gnrc/netif/hdr/gnrc_netif_hdr_print.c:23

(:

@kYc0o
Copy link
Contributor Author

kYc0o commented Apr 10, 2016

oups... my reading skills are decreasing...

@kYc0o kYc0o force-pushed the gnrc_netdev2_ieee802154_debug branch 5 times, most recently from dd683c3 to 88b1742 Compare April 10, 2016 14:18
@kYc0o kYc0o force-pushed the gnrc_netdev2_ieee802154_debug branch from 88b1742 to 6df58ac Compare April 10, 2016 14:32
@cgundogan cgundogan added Area: network Area: Networking GNRC CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 10, 2016
@cgundogan
Copy link
Member

ACK

@cgundogan
Copy link
Member

Murdock is green - GO

@cgundogan cgundogan merged commit 8c4003f into RIOT-OS:master Apr 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants