dist/ethos: fixed compile warnings

[haukepetersen]

• checking return values of each write() call
• chack return value of system() call

[kaspar030]

fprintf(stderr, "write to fd %i failed: %s\n", handle, strerror(errno)));

[kaspar030]

Much better. I you feel like, add the actual error message to the output (see other comment). ACK.

[haukepetersen]

fixed write error message and squashed.

[haukepetersen]

just came to mind when setting the 'read for...' label: tools like ethos are not checked by the CI in any case, right? Does it make sense to include them (open an issue for that)? I think it might not be too bad to do this...

[kaspar030]

a ")" too much:

[kaspar@booze ethos (test)]$ make
cc -O3 -Wall ethos.c -o ethos
ethos.c: In function ‘checked_write’:
ethos.c:39:80: error: expected ‘;’ before ‘)’ token
         fprintf(stderr, "write to fd %i failed: %s\n", handle, strerror(errno)));
                                                                                ^
ethos.c:39:80: error: expected statement before ‘)’ token
Makefile:4: recipe for target 'ethos' failed
make: *** [ethos] Error 1
[kaspar@booze ethos (test)]$

[kaspar030]

tools like ethos are not checked by the CI in any case, right? Does it make sense to include them (open an issue for that)? I think it might not be too bad to do this...

yes and yes...

[haukepetersen]

done #5319

[haukepetersen]

so are you bold enough to just merge this?

[kaspar030]

Did you fix the bracket?

[kaspar030]

haukepetersen#27

[haukepetersen]

nope, github did not update the view before my comments, so I did not see your input.

[haukepetersen]

squashed

[kaspar030]

compiled & tested here, works like a charm. skipping murdock as this doesn't get compiled anywasy. go!

[kaspar030]

Thanks @haukepetersen for taking the time to clean up my sloppyness!

[haukepetersen]

my pleasure :-)

[cgundogan]

does this need backporting?

[haukepetersen]

yes