Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6: Revert #5179 #5326

Merged
merged 2 commits into from
Apr 20, 2016
Merged

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 17, 2016

Reverts #5179.

Alternative to #5247.

Else-case that was discussed #5247 isn't necessary, since iface is already initialized with KERNEL_PID_UNDEF.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking GNRC Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Apr 17, 2016
@miri64 miri64 added this to the Release 2016.04 milestone Apr 17, 2016
@OlegHahm
Copy link
Member

Just a small question: would NDP work without a netif header for devices with multiple interfaces? IIRC it guesses the interface by matching the interface's addresses to the source address of the sender, right?

@miri64
Copy link
Member Author

miri64 commented Apr 17, 2016

Usually NDP shouldn't go over loopback or similar interfaces, so I think it should work. The default behavior for an unknown interface should be to multicast the pacaket (the reply) then (all-routers for RS, all-nodes for all other).

@miri64
Copy link
Member Author

miri64 commented Apr 17, 2016

I'm not sure where you have the "guessing" from. Can't find any of such things in the code.

@miri64
Copy link
Member Author

miri64 commented Apr 17, 2016

The default behavior for an unknown interface should be to multicast the pacaket (the reply) then (all-routers for RS, all-nodes for all other).

If no reply for a packet is expected the packet should be ignored anyways, since it obviously did not came from a "real" interface.

@OlegHahm
Copy link
Member

I'm not sure where you have the "guessing" from. Can't find any of such things in the code.

I was referring to:
https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c#L734

@miri64
Copy link
Member Author

miri64 commented Apr 18, 2016

Ah, but that is not guessing, actually. If the address is assigned to the interface it is assigned to the interface and there is no ambiguity.

@OlegHahm
Copy link
Member

But one can receive a packet that is targeted for an addressed assigned to interface A on interface B, right?

@miri64
Copy link
Member Author

miri64 commented Apr 19, 2016

But one can receive a packet that is targeted for an addressed assigned to interface A on interface B, right?

Yes, but didn't we asses, that for "real" interfaces there is always a netif header, so iface isn't KERNEL_PID_UNDEF at this point?

@OlegHahm
Copy link
Member

Hopefully.

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 20, 2016
@haukepetersen
Copy link
Contributor

ACK

@haukepetersen
Copy link
Contributor

Murdock is happy -> go.

@haukepetersen haukepetersen merged commit 4ace701 into RIOT-OS:master Apr 20, 2016
@miri64 miri64 deleted the gnrc_ipv6/fix/revert5179 branch April 20, 2016 12:34
@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants