kinetis: Adjust RTT alarm trigger time #7476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RTT alarm will trigger when the RTT seconds register is equal to the set alarm target, instead of triggering at the following second.
jnohlgard
added
Platform: ARM
aabadie
reviewed
Sep 13, 2017
| RTC_Type *rtt = RTT_DEV; | ||
|
|
||
| /* Disable Timer Alarm Interrupt */ | ||
| rtt->IER &= ~(RTC_IER_TAIE_MASK); | ||
|
|
||
| rtt->TAR = alarm; | ||
| rtt->TAR = alarm - 1; |
There was a problem hiding this comment.
What happens if one passes 0 as alarm ? It doesn't make sense but maybe we should ensure alarm is greater than 1 ?
There was a problem hiding this comment.
It should actually still be correct, the alarm will be set to trigger when the counter is equal to 0xffffffff and increments, i.e. when the counter turns 0.
aabadie
added
the
CI: ready for build
aabadie
approved these changes
Oct 9, 2017
|
Tested ACK. Go! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTT alarm will trigger when the RTT seconds register is equal to the set alarm target, instead of triggering at the following second. This makes the API behave more like what users seem to expect.
Fixes #6331 for Kinetis