-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: fixing (some) special chars #7571
Conversation
smlng
commented
Sep 5, 2017
•
edited
Loading
edited
btw. used I had some hard time lately debugging some code, that was copy-pasted and had weird (non-visible) chars in it, so checked RIOT as well ... |
6dd505b
to
e72faae
Compare
Weird white-spaces I get (and to an extend the dash thing as well), but why do we need to remove the rest? The code is encoded in unicode, not ASCII. |
pkg/openthread/include/ot.h
Outdated
@@ -17,7 +17,7 @@ | |||
* | |||
* @file | |||
* | |||
* @author Jos� Ignacio Alamos <jialamos@uc.cl> | |||
* @author José Ignacio Alamos <jialamos@uc.cl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the é
of José looks weird when viewed in Atom or VIM editors, obviously it doesn't on github.
@@ -66,7 +66,7 @@ index 2912049..682b7c2 100644 | |||
#include "ctimer.h" | |||
-#include "random.h" | |||
+#include "emb6_random.h" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing patch files this way can potentially end badly ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, you're right, that was unintentional. There are other patches with such, which I left out.
I don't get it. What gets replaced with what? I suppose you're replacing wierd ascii with the correct UTF-8? |
e72faae
to
e3a3b49
Compare
I refactored the PR into smaller commits to clarify what is done where, also removed the fixes in that patch file. Btw. this how a part of the diff looks on my terminal (which looks different when viewed on GitHub): mrf24j40_reg_write_long(dev, MRF24J40_REG_RFCON0, channel_value);
/*
- * Note:Perform an RF State Machine Reset (see Section 3.1 <93>Reset<94>)
+ * Note: Perform an RF State Machine Reset (see Section 3.1 Reset)
* after a channel frequency change. Then, delay at least 192 us after
* the RF State Machine Reset, to allow the RF circuitry to calibrate.
*/
@@ -373,7 +373,7 @@ void mrf24j40_set_option(mrf24j40_t *dev, uint16_t option, bool state)
tmp |= MRF24J40_TXMCR_NOCSMA;
/* MACMINBE<1:0>: The minimum value of the backoff exponent
* in the CSMA-CA algorithm. Note that if this value is set
- * to <91>0<92>, collision avoidance is disabled. */
+ * to 0, collision avoidance is disabled. */
mrf24j40_reg_write_short(dev, MRF24J40_REG_TXMCR, tmp); |
e3a3b49
to
ae1833c
Compare
Did you do this via script or manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.