Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: add cn-cbor CBOR implementation #8025

Closed
wants to merge 3 commits into from

Conversation

kaspar030
Copy link
Contributor

From https://github.com/cabo/cn-cbor: "A constrained node implementation of CBOR in C".

@kaspar030 kaspar030 added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2017
@kaspar030 kaspar030 mentioned this pull request Nov 13, 2017
6 tasks


def testfunc(child):
child.expect('[SUCCESS]')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be child.expect_exact if you keep the brackets.

@jnohlgard
Copy link
Member

There is a test vector included with the library, so you think it would be possible to work it into the RIOT test application to make it possible to verify the implementation on the actual device?
This module will likely be a useful part for future OTA firmware update solutions, and it is important that it's possible to verify the implementation.

@miri64
Copy link
Member

miri64 commented Nov 16, 2017

I agree with @gebart to use the test vector for testing.

@kaspar030
Copy link
Contributor Author

There is a test vector included with the library, so you think it would be possible to work it into the RIOT test application to make it possible to verify the implementation on the actual device?

I guess so, but the code is far from RIOT compliant. Honestly, I don't have time to adapt/integrate that. Any volunteers?

@lorenz9314
Copy link
Contributor

I guess so, but the code is far from RIOT compliant. Honestly, I don't have time to adapt/integrate that. Any volunteers?

We from the Beduino Project would actually be interested in seeing cn-cbor in RIOT and are willing to spend some effort on this. What exactly do you mean by "not RIOT compliant"? The Test, -vectors, cn-cbor in general?

@kaspar030
Copy link
Contributor Author

What exactly do you mean by "not RIOT compliant"? The Test, -vectors, cn-cbor in general?

I'm talking about the tests. For coding convention reasons, they cannot simply be copied into RIOT's unittests, but would need quite some rework. Maybe it would be simpler to write a couple of new unittests (testing cn-cbors basic functionality) from scratch.

(API-)-style-wise, cn-cbor is not very RIOTy, but as it is just a library that we'd like to support as a package, it doesn't matter.

@smlng
Copy link
Member

smlng commented Feb 6, 2018

@kaspar030 can you look into this again, seems others are interested in this too. However, Murdock is a bit unhappy ...

@kaspar030
Copy link
Contributor Author

closed in favor of #8467.

@kaspar030 kaspar030 closed this Feb 6, 2018
@kaspar030 kaspar030 deleted the add_pkg_cn-cbor branch February 6, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants