New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg: add cn-cbor CBOR implementation #8025
Conversation
|
||
|
||
def testfunc(child): | ||
child.expect('[SUCCESS]') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be child.expect_exact
if you keep the brackets.
There is a test vector included with the library, so you think it would be possible to work it into the RIOT test application to make it possible to verify the implementation on the actual device? |
I agree with @gebart to use the test vector for testing. |
I guess so, but the code is far from RIOT compliant. Honestly, I don't have time to adapt/integrate that. Any volunteers? |
We from the Beduino Project would actually be interested in seeing cn-cbor in RIOT and are willing to spend some effort on this. What exactly do you mean by "not RIOT compliant"? The Test, -vectors, cn-cbor in general? |
I'm talking about the tests. For coding convention reasons, they cannot simply be copied into RIOT's unittests, but would need quite some rework. Maybe it would be simpler to write a couple of new unittests (testing cn-cbors basic functionality) from scratch. (API-)-style-wise, cn-cbor is not very RIOTy, but as it is just a library that we'd like to support as a package, it doesn't matter. |
@kaspar030 can you look into this again, seems others are interested in this too. However, Murdock is a bit unhappy ... |
closed in favor of #8467. |
From https://github.com/cabo/cn-cbor: "A constrained node implementation of CBOR in C".