Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/adxl345: apply unified params definition scheme #8671

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 28, 2018

Contribution description

This PR update the params definitions scheme for the adxl345 device driver.

Issues/PRs references

Initially done in #7937 and related to #7519

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 28, 2018
@aabadie aabadie requested a review from dylad February 28, 2018 15:29
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good !


void auto_init_adxl345(void)
{
assert(ADXL345_INFO_NUM == ADXL345_NUM);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider #8669 (comment) before merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible (see #8669 (comment)) so let's rebuild and then go.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 7, 2018
@miri64 miri64 merged commit ade3846 into RIOT-OS:master Mar 7, 2018
@aabadie aabadie deleted the pr/drivers/params/adxl345 branch June 8, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants