Basic support for CC430 radio module

[baptiste-cartier]

Contribution description

This is a basic implementation for the cc430 radio module, enabling the use of this cpu radio capabilities. It comes with a configuration example file with two example configurations, one in transmit mode and one in receive mode.

The goal of this implementation is to give a fast and simple way to use the cc430 radio module for basic communications.

Issues/PRs references

[smlng]

Just a quick one, as response to your mail: see comment, this should fix the headerguard check errors in travis.

However, besides that: please review RIOT coding style conventions, see Wiki.

[smlng]

add newline at the end

[smlng]

add newline at the end

[baptiste-cartier]

Thanks, I totally forgot about that one.

However, could you point me what does not comply with RIOT coding style conventions? I tried to follow them as much as I could, and I don't see which one I have not followed correctly.

[smlng]

see wiki for coding conventions. Also see my comments to get you started

[baptiste-cartier]

Thanks for the answer, that was it, Regards, Baptiste 2018-03-21 16:08 GMT+01:00 Sebastian Meiling <notifications@github.com>:

…

***@***.**** requested changes on this pull request. Just a quick one, as response to your mail: see comment, this should fix the headerguard check errors in travis. However, besides that: please review RIOT coding style conventions, see Wiki. ------------------------------ In cpu/cc430/include/cc430_radio.h <#8811 (comment)>: > +void cc430_radio_read_burst_reg(uint8_t addr, void *buffer, uint8_t count); +void cc430_radio_write_burst_reg(uint8_t addr, void *buffer, uint8_t count); +void cc430_radio_reset_radio_core(void); +int8_t cc430_radio_write_pa_table(uint8_t value); +void cc430_radio_transmit(void *buffer, uint8_t length); +void cc430_radio_receive(void *buffer, uint8_t *length); +void cc430_radio_receive_on(void); +void cc430_radio_receive_off(void); +void cc430_radio_write_rf_reg(const uint8_t SmartRFSetting[][2], uint8_t size); + + +#ifdef __cplusplus +} +#endif + +#endif /* CC430_RADIO_H */ add newline at the end ------------------------------ In cpu/cc430/include/cc430_radio_rfsetting.h <#8811 (comment)>: > +#define CC430_RADIO_RFSETTING_FSCAL1 0x00 +#define CC430_RADIO_RFSETTING_FSCAL0 0x1F +#define CC430_RADIO_RFSETTING_FSTEST 0x59 +#define CC430_RADIO_RFSETTING_PTEST 0x7F +#define CC430_RADIO_RFSETTING_AGCTEST 0x3F +#define CC430_RADIO_RFSETTING_TEST2 0x81 +#define CC430_RADIO_RFSETTING_TEST1 0x35 +#define CC430_RADIO_RFSETTING_TEST0 0x0B + +#endif /*RECEIVE_OR_TRANSMIT == 1*/ + +#ifdef __cplusplus +} +#endif + +#endif /* CC430_RADIO_RFSETTING_H */ add newline at the end — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8811 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AjpZBsSFnX7Qzfv4C5H98MN0KtJCUOTrks5tgmz1gaJpZM4Sz8tJ> .

[smlng]

remove additional empty lines, review code below

[smlng]

add missing closing group * @}

[smlng]

the file name doesn't match, also we mostly omit that explicit name

[smlng]

please define a group with drivers_cc430

[smlng]

Before you move on here: there already is a driver for the cc110x how does this differ or improve on that?

[baptiste-cartier]

The CC430 is a MCU based on the MSP430 with a radio core based on the cc1101. The means to access the radio on the cc430 is different that simply using a cc110x. Using the radio module of the CC430 implies writing specific data to specific registers of the CC430, meaning the driver for the cc110x can not be used in this context. This provides a basic mean to use the radio module and can be used as a base to build a more complex and complete API.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.