net/rdcli_common: fix EP name generation #8905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Type: bug
|
Travis complaints ignored as with #7406 |
|
@haukepetersen I noticed that the endpoint name generation doesn't work correctly for an odd suffix length (suffix length of 3 results in an actual length of 2 here). As it is not directly configurable by the end user and the issue is already present in the original implementation I don't want to complain about it here. Do you want an issue for it or leave it as it is? :) |
|
good point. How about #8906 |
This could have been avoided by having a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When doing the last fixes to #7406, an un-noticed bug slept in -> the generation of the EP name is in master now terminated in the middle of the string, so the actual ID part or the name is dropped.
This PR fixes this and also simplifies the code slightly.
Issues/PRs references
fix for #7406