pkg/jerryscript: update to latest commit

[anthonydurot]

Contribution description

I updated the Makefile into pkg/javascript with the latest commit of JerryScript so that the API on JerryScript : http://jerryscript.net/api-reference/ is up to date with RIOT package version.

Issues/PRs references

The function used before are no longer supported by JerryScript, such as :

RIOT/examples/javascript/main.c

Line 45 in 28f2eaa

if (!jerry_value_has_error_flag(ret_value)) {

(See this PR on JerryScript :
jerryscript-project/jerryscript@ba2e49c )

Also, the jerry_parse function used here :

RIOT/examples/javascript/main.c

Line 43 in 28f2eaa

ret_value = jerry_parse(script, script_size, false);

Is no longer supported by JerryScript since this PR :

jerryscript-project/jerryscript@96b528a

[kYc0o]

Hi @Lydrin ! Welcome to RIOT and thanks for your contribution.

Just as a reminder (maybe you have already seen it in the contributions doc), we enforce the commit messages in the format of pkg/jerryscipt: update to latest commit or examples/jerryscript: adapt to updated pkg. Also, keep in mind that we also enforce working commits to ease bisect if needed, as well as a more explanatory description on the commit message if needed (though no more than 72 characters per line).

I'll take a look soon and give feedback. Thanks again!

[kYc0o]

+1 for the changes, they're legit and improve the example with few more checks. I have just a minor comment, with that addressed I'm ok to merge.

@kaspar030 would this break some of your applications?

[kYc0o]

This extra line is not needed.

[kYc0o]

@kaspar030 ping!

[kaspar030]

@kaspar030 would this break some of your applications?

Maybe, but I'll adapt acordingly. go ahead with this!

[kYc0o]

ACK.